Coccinelle Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Brice.Goglin@inria.fr (Brice Goglin)
To: cocci@systeme.lip6.fr
Subject: [Cocci] "virtual rule patch not supported"
Date: Fri, 15 Mar 2013 16:03:14 +0100	[thread overview]
Message-ID: <51433832.1010906@inria.fr> (raw)
In-Reply-To: <CAAxaTiOFoDmDm+38XhALBp0ZtMNbpg7D8td-K7H2A30PRGkgRA@mail.gmail.com>

Le 15/03/2013 15:49, Nicolas Palix a ?crit :
> Hi,
>
> On Wed, Mar 13, 2013 at 9:47 AM, Julia Lawall <julia.lawall@lip6.fr> wrote:
>> On Mon, 11 Mar 2013, Brice Goglin wrote:
>>
>>> Hello,
>>> I am running the kernel 3.9-rc2 coccicheck script on some of my module,
>>> and I get the following message:
>>>   virtual rule patch not supported
>> I guess it doesn't crash?  It is possible that some semantic patch just
>> doesn't support the patch option.  I don't remember if it is possible to
>> specify several options, and to have them tried in order?  That could be a
>> nice feature.  If not, I think that there is an option that tries all of
>> the options in a fixed order.  Nicolas?
>>
> According to the cocci files, every coccicheck mode could not be proposed.
> It is indeed some time impossible to propose a bug correction because
> several options are available for a single bug report and the semantic
> patch is not designed to choose one.
>
> The current basic modes are: patch, report, context, org
> The 'chain' mode tries the following mode is order: patch || report ||
> context || org.
> Recently, the 'rep+ctxt' mode have been added for report and context modes.
>
> If you haven't specify the mode, it defaults to chain. The patch mode
> is thus tried first.
> If it fails, coccicheck falls back to the report mode.
>

In short, this warning is harmless ?

Should it be disabled in the kernel by default ? Most people that uses
coccicheck in the kernel don't know much about it, and they don't write
the rules directly, so they may be afraid by the warning just like me.

Brice

  reply	other threads:[~2013-03-15 15:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-11  8:25 [Cocci] "virtual rule patch not supported" Brice Goglin
2013-03-13  8:47 ` Julia Lawall
2013-03-15 14:49   ` Nicolas Palix
2013-03-15 15:03     ` Brice Goglin [this message]
2013-03-15 15:11       ` Nicolas Palix
2013-03-15 15:14         ` Nicolas Palix
2013-03-15 18:06           ` Brice Goglin
2013-03-15 22:16           ` Julia Lawall
2013-03-15 22:17       ` Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51433832.1010906@inria.fr \
    --to=brice.goglin@inria.fr \
    --cc=cocci@systeme.lip6.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox