From: mstefani@redhat.com (Michael Stefaniuc)
To: cocci@systeme.lip6.fr
Subject: [Cocci] disjunction and parens
Date: Fri, 09 Aug 2013 12:56:20 +0200 [thread overview]
Message-ID: <5204CAD4.9020507@redhat.com> (raw)
In-Reply-To: <CAP6exY+yyWBN5LPF7fT5KHuGe8VM4z0R5ywJ08Pq2rwOO3Hxaw@mail.gmail.com>
On 08/07/2013 05:21 PM, ron minnich wrote:
> I've never been sure what to do about this error:
>
> [rminnich at localhost akaros]$ spatch --sp-file !$ kern/src/chan.c
> spatch --sp-file scripts/spatch/waserror.cocci kern/src/chan.c
> init_defs_builtins: /usr/share/coccinelle/standard.h
> Fatal error: exception Failure("normal parenthesis in line 5 matched
> to disjunction parenthesis on line 7 column 0
>
> Spatch is:
>
> @@
> type T;
> identifier f;
> @@
> T F(...,
> +struct errbuf *errbuf
> ){...}
>
> What did I do wrong here?
) is special when it is on the first column in a line. If you add a
space before it, it will just work. It is a good practice to start code
matching lines with a space; like the context lines in the unified diff
format.
bye
michael
prev parent reply other threads:[~2013-08-09 10:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-07 15:21 [Cocci] disjunction and parens ron minnich
2013-08-07 15:29 ` [Cocci] " ron minnich
2013-08-09 10:56 ` Michael Stefaniuc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5204CAD4.9020507@redhat.com \
--to=mstefani@redhat.com \
--cc=cocci@systeme.lip6.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox