From mboxrd@z Thu Jan 1 00:00:00 1970 From: mmarek@suse.cz (Michal Marek) Date: Wed, 06 Aug 2014 11:34:42 +0200 Subject: [Cocci] [PATCH] Coccinelle: Script to replace if and BUG with BUG_ON In-Reply-To: References: <20140720213635.GA12365@himangi-Dell> <53E0E9D0.9040500@suse.cz> Message-ID: <53E1F6B2.90201@suse.cz> To: cocci@systeme.lip6.fr List-Id: cocci@systeme.lip6.fr On 2014-08-05 20:16, Julia Lawall wrote: > > > On Tue, 5 Aug 2014, Michal Marek wrote: > >> On 2014-07-20 23:36, Himangi Saraogi wrote: >>> This script detects cases where BUG() follows an if condition on an >>> expression and replaces the if condition and BUG() with a BUG_ON having >>> the conditional expression of the if statement as argument. >>> >>> Signed-off-by: Himangi Saraogi >>> Acked-by: Julia Lawall >> >> Is this a result of some internal review, or where does Julia's Acked-by >> come from? I'm just wondering, because I haven't seen any previous >> version of this patch. > > She sent it to me first. It's OK with me. OK, thanks for confirming. I'm going to merge this and the previous patches by Himangi. Michal