From: mmarek@suse.cz (Michal Marek)
To: cocci@systeme.lip6.fr
Subject: [Cocci] [PATCH 1/2] scripts/coccinelle/misc/semicolon.cocci: Use imperative mood
Date: Wed, 20 May 2015 13:46:07 +0800 [thread overview]
Message-ID: <555C1F9F.8030206@suse.cz> (raw)
In-Reply-To: <alpine.DEB.2.02.1505091843250.2077@localhost6.localdomain6>
Dne 10.5.2015 v 00:44 Julia Lawall napsal(a):
>
>
> On Sat, 9 May 2015, Fabio Estevam wrote:
>
>> From: Fabio Estevam <fabio.estevam@freescale.com>
>>
>> According to Documentation/SubmittingPatches:
>>
>> "Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
>> instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy
>> to do frotz", as if you are giving orders to the codebase to change
>> its behaviour.
>>
>> So do as recommended.
>>
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>
> Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Fabio, could you please resend me these two patches? It seems I wasn't
on CC (or I accidentally dropped them :)).
Michal
prev parent reply other threads:[~2015-05-20 5:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-09 15:26 [Cocci] [PATCH 1/2] scripts/coccinelle/misc/semicolon.cocci: Use imperative mood Fabio Estevam
2015-05-09 15:26 ` [Cocci] [PATCH 2/2] scripts/coccinelle/misc/irqf_oneshot.cocci: Fix grammar Fabio Estevam
2015-05-09 16:43 ` Julia Lawall
2015-05-09 16:44 ` [Cocci] [PATCH 1/2] scripts/coccinelle/misc/semicolon.cocci: Use imperative mood Julia Lawall
2015-05-20 5:46 ` Michal Marek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555C1F9F.8030206@suse.cz \
--to=mmarek@suse.cz \
--cc=cocci@systeme.lip6.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox