Coccinelle Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: elfring@users.sourceforge.net (SF Markus Elfring)
To: cocci@systeme.lip6.fr
Subject: [Cocci] Deletion of blank lines?
Date: Thu, 16 Jul 2015 07:41:07 +0200	[thread overview]
Message-ID: <55A743F3.6000500@users.sourceforge.net> (raw)
In-Reply-To: <55A60721.5050209@users.sourceforge.net>

>  void receiver(...)
>  {
>   ...
> (
> - exit(...);
> |
> - fprintf(...);
> )
>   ...
>  }
> ?
> diff -u -p a/backend/ipp.c b/backend/ipp.c
> --- a/backend/ipp.c
> +++ b/backend/ipp.c
> @@ -3271,8 +3271,6 @@ sigterm_handler(int sig)          /* I - Signal
>  
>    if (tmpfilename[0])
>      unlink(tmpfilename);
> -
> -  exit(1);

I find another detail interesting in this generated patch.
The Coccinelle software suggests here to delete also a blank line
at a specific source code place. I would usually interpret
this SmPL script example in the way that I did not express the removal
of blank lines.

How often do you care if additional source code reformatting should
happen around a specific change (or not)?

Regards,
Markus

  parent reply	other threads:[~2015-07-16  5:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-15  7:09 [Cocci] Checking signal handler implementations with SmPL SF Markus Elfring
2015-07-15 14:27 ` Julia Lawall
2015-07-15 20:38   ` SF Markus Elfring
2015-07-16  5:41 ` SF Markus Elfring [this message]
2015-07-17  9:50   ` [Cocci] Deletion of blank lines? Julia Lawall
2015-07-17 11:12     ` SF Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55A743F3.6000500@users.sourceforge.net \
    --to=elfring@users.sourceforge.net \
    --cc=cocci@systeme.lip6.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox