public inbox for cocci@systeme.lip6.fr
 help / color / mirror / Atom feed
From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
To: Jacob Keller <jacob.e.keller@intel.com>,
	Markus Elfring <Markus.Elfring@web.de>
Cc: <cocci@inria.fr>
Subject: Re: [cocci] behavior change in semantic patches since c36b51ffc889 …
Date: Tue, 11 Mar 2025 10:26:09 +0100	[thread overview]
Message-ID: <563307e0-08b8-4eac-9d62-4c4e889d86cd@intel.com> (raw)
In-Reply-To: <db753272-0294-4ea1-ad9f-bc210998267b@intel.com>

>> Are you looking for ways to avoid extra efforts for code reformatting?
>>
> 
> In my experience, our existing coding style is not 100% replicated in
> any of the formatting tools. It would take a significant effort to get
> to the point where we could run a formatting tool without completely
> re-formatting the entire code base.

The most problematic rule is "don't reformat code you don't touch",
so the formatter needs to limit it's scope.

Not only to the lines touched, but "things touched", see:

-	int var = ...;
+	int val = ...;

	// ...

-	err = long_call_a_bit_wrong_perhaps_too_long_line(var, other);
+	err = long_call_a_bit_wrong_perhaps_too_long_line(val, other);

so, the rename of poor "var" to better (but same length) "val",
you don't want to break long_call_a_bit_wrong_perhaps_too_long_line()
into multiple lines here

  reply	other threads:[~2025-03-18  9:11 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-07  0:43 [cocci] behavior change in semantic patches since c36b51ffc889 ("don't drop down on single statement") Jacob Keller
2025-03-07  0:55 ` Julia Lawall
2025-03-07 20:24   ` Jacob Keller
2025-03-07 10:47 ` [cocci] behavior change in semantic patches since c36b51ffc889 … Markus Elfring
2025-03-07 20:53   ` Jacob Keller
2025-03-07 22:47     ` Jacob Keller
2025-03-08  9:07       ` Markus Elfring
2025-03-10 18:34         ` Jacob Keller
2025-03-11  9:10           ` Markus Elfring
2025-03-08  8:39     ` Markus Elfring
2025-03-10 18:27       ` Jacob Keller
2025-03-11  9:26         ` Przemek Kitszel [this message]
2025-03-08  9:45     ` [cocci] Evolution of transformation processes? Markus Elfring
2025-03-10 18:23       ` Jacob Keller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=563307e0-08b8-4eac-9d62-4c4e889d86cd@intel.com \
    --to=przemyslaw.kitszel@intel.com \
    --cc=Markus.Elfring@web.de \
    --cc=cocci@inria.fr \
    --cc=jacob.e.keller@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox