From: peter@hurleysoftware.com (Peter Hurley)
To: cocci@systeme.lip6.fr
Subject: [Cocci] how to find missing initializer
Date: Thu, 3 Dec 2015 08:04:03 -0500 [thread overview]
Message-ID: <56603DC3.8040609@hurleysoftware.com> (raw)
Hi all,
I'm struggling with the grammar necessary to find struct definitions
missing an initializer.
The background is that many tty interfaces include a method/operations
table (named fields of function ptrs). For example, given a declaration
like,
struct tty_operations {
int (*install)( /* ... */ );
int (*remove)( /* ... */ );
void (*cleanup)( /* ... * );
...
};
a tty driver might define its method table like,
static const struct tty_operations ops = {
.install = uart_install,
.remove = uart_remove,
.cleanup = uart_cleanup,
...
};
(actually, this is a common pattern throughout the kernel)
Many operations are optional; a NULL method is simply not executed.
For example,
if (tty->ops->cleanup)
tty->ops->cleanup(tty);
So trying to find those in-tree drivers which _do not_ define a cleanup
method with coccinelle, led to this fragment which has a parse error.
Apologies if my question is obvious or trivial; I'm still learning
coccinelle.
Regards,
Peter Hurley
--- >% ---
virtual context
@ depends on context @
identifier fops;
identifier fn;
@@
* struct tty_operations fops = {
... when != .cleanup = fn,
...
};
next reply other threads:[~2015-12-03 13:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-03 13:04 Peter Hurley [this message]
2015-12-03 18:46 ` [Cocci] how to find missing initializer Lars-Peter Clausen
2015-12-03 22:12 ` Julia Lawall
2015-12-03 23:48 ` Luis R. Rodriguez
2015-12-04 13:55 ` [Cocci] Searching with SmPL for missing clean-up settings in designated initialisers SF Markus Elfring
2015-12-04 14:44 ` Julia Lawall
2015-12-04 15:42 ` SF Markus Elfring
2015-12-04 11:31 ` [Cocci] how to find missing initializer SF Markus Elfring
2015-12-04 13:18 ` Julia Lawall
2015-12-04 11:54 ` Peter Hurley
2015-12-03 19:26 ` Luis R. Rodriguez
2015-12-04 8:55 ` SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56603DC3.8040609@hurleysoftware.com \
--to=peter@hurleysoftware.com \
--cc=cocci@systeme.lip6.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox