Coccinelle Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolas.Palix@imag.fr (Nicolas Palix (LIG))
To: cocci@systeme.lip6.fr
Subject: [Cocci] [PATCH] coccicheck: Fix missing 0 index in kill loop
Date: Tue, 17 May 2016 16:32:41 +0200	[thread overview]
Message-ID: <573B2B89.7060004@imag.fr> (raw)
In-Reply-To: <20160516125558.GA352@www.outflux.net>

Le 16/05/16 14:55, Kees Cook a ?crit :
> By default, "seq" counts from 1, but processes were starting counting
> from 0, so when interrupted, coccicheck would leave the 0th process
> running.
> 
> Signed-off-by: Kees Cook <keescook@chromium.org>

Acked-by: Nicolas Palix <nicolas.palix@imag.fr>


> ---
>  scripts/coccicheck | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/coccicheck b/scripts/coccicheck
> index b2d758188f2f..dd85a455b2ba 100755
> --- a/scripts/coccicheck
> +++ b/scripts/coccicheck
> @@ -98,7 +98,7 @@ run_cmd() {
>  }
>  
>  kill_running() {
> -	for i in $(seq $(( NPROC - 1 )) ); do
> +	for i in $(seq 0 $(( NPROC - 1 )) ); do
>  		if [ $VERBOSE -eq 2 ] ; then
>  			echo "Killing ${SPATCH_PID[$i]}"
>  		fi
> 


-- 
Nicolas Palix
http://lig-membres.imag.fr/palix/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 2959 bytes
Desc: Signature cryptographique S/MIME
URL: <https://systeme.lip6.fr/pipermail/cocci/attachments/20160517/5fcdf348/attachment.p7s>

  reply	other threads:[~2016-05-17 14:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-16 12:55 [Cocci] [PATCH] coccicheck: Fix missing 0 index in kill loop Kees Cook
2016-05-17 14:32 ` Nicolas Palix (LIG) [this message]
2016-05-17 14:33   ` Julia Lawall
2016-05-19  7:57     ` Michal Marek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=573B2B89.7060004@imag.fr \
    --to=nicolas.palix@imag.fr \
    --cc=cocci@systeme.lip6.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox