[cocci] Deleting duplicate condition checks (with SmPL)?

[Markus Elfring <Markus.Elfring@web.de>]

Hello,

I noticed another contribution.

I got into the mood to construct another script for the semantic patch language.


// See also:
// [PATCH net-next] ipv6: mcast: Remove unnecessary null check in mld_del_delrec()
// https://lore.kernel.org/lkml/20250712092811.2992283-1-yuehaibing@huawei.com/
//
// https://elixir.bootlin.com/linux/v6.16-rc5/source/net/ipv6/mcast.c#L786-L813
@deletions@
expression x;
@@
 if (x)
 {
 <+...
-}
-if (x)
-{
 ...+>
 }


Questionable test result (by the software combination “Coccinelle 1.3.0” for example):
Markus_Elfring@Sonne:…/Projekte/Coccinelle/janitor> /usr/bin/spatch --parse-cocci delete_duplicate_condition_checks2.cocci
…
minus: parse error: 
  File "delete_duplicate_condition_checks2.cocci", line 12, column 1, charpos = 307
  around = '}',
  whole content = -}


The transformation approach is working as expected if the specification “... when any”
would be applied instead of the SmPL nest construct.
Which software improvements will become more desirable for such an use case?

Regards,
Markus