From: julia.lawall@lip6.fr (Julia Lawall)
To: cocci@systeme.lip6.fr
Subject: [Cocci] [cocci-bug] coccinelle 1.0.6: OpenMP #pragma directive leads to function ignore
Date: Thu, 26 Apr 2018 11:22:46 +0100 (WEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1804261121540.7389@hadrien> (raw)
In-Reply-To: <20180426102122.GB7703@localhost>
On Thu, 26 Apr 2018, Michele Martone wrote:
> On 20180426 at 09:25, Julia Lawall wrote:
> > On Thu, 26 Apr 2018, Michele Martone wrote:
> >
> > > Dear Prof. Lawall and Coccinelle team,
> > >
> > > I'm an enthusiastical, however still beginner use of Coccinelle.
> > >
> > > While running spatch 1.0.6 on a long OpenMP-enabled listing, I
> > > noticed that the presence of the C line:
> > > #pragma omp parallel for reduction(+:I) private(I)
> > > seems to prevent restructuring of the function containing it.
> > > If I simplify the pragma to something like
> > > #pragma omp parallel
> > > the problem disappears.
> > >
> > > Is there anything I can do to restructure large codes containing
> > > many of such similar lines ?
> > >
> > > In the attachment you find a test case and the output I experience.
> >
> > Thanks for the report. We can try to make the parsing of #pragmas more
> > flexible.
> >
> > julia
>
> Dear Julia,
>
> thanks for the quick response!
>
> I'll be waiting for Coccinelle-sided developments then.
>
> May I ask what would you recommend now to circumvent this ?
>
> From the SmPL v1.0.6 Grammar I am not aware of any way to
> e.g. ignore pragma lines as they were comments.
>
> So the best what comes to my mind is to:
>
> - comment #pragma lines
> - compute semantic patch
> - apply semantic patch
> - uncomment #pragma lines
>
> If there is any better solution, please let me know.
I don't see any other solution, sorry. For some other parsing issues, it
might be possible to define a macro, but that is not possible here.
julia
next prev parent reply other threads:[~2018-04-26 10:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-26 8:12 [Cocci] [cocci-bug] coccinelle 1.0.6: OpenMP #pragma directive leads to function ignore Michele Martone
2018-04-26 8:25 ` Julia Lawall
2018-04-26 10:21 ` Michele Martone
2018-04-26 10:22 ` Julia Lawall [this message]
2018-04-30 6:43 ` Julia Lawall
2018-04-30 7:39 ` Michele Martone
2018-04-30 7:42 ` Julia Lawall
2018-04-30 7:47 ` Michele Martone
2018-04-30 7:44 ` Peter Senna Tschudin
2018-05-02 13:16 ` Michele Martone
2018-05-25 13:56 ` Michele Martone
2018-04-26 13:01 ` [Cocci] Coccinelle " SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1804261121540.7389@hadrien \
--to=julia.lawall@lip6.fr \
--cc=cocci@systeme.lip6.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox