From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2E44C433E0 for ; Wed, 17 Jun 2020 21:15:55 +0000 (UTC) Received: from isis.lip6.fr (isis.lip6.fr [132.227.60.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2AEE121841 for ; Wed, 17 Jun 2020 21:15:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2AEE121841 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=inria.fr Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=cocci-bounces@systeme.lip6.fr Received: from systeme.lip6.fr (systeme.lip6.fr [132.227.104.7]) by isis.lip6.fr (8.15.2/8.15.2) with ESMTP id 05HLFcAM015684; Wed, 17 Jun 2020 23:15:39 +0200 (CEST) Received: from systeme.lip6.fr (systeme.lip6.fr [127.0.0.1]) by systeme.lip6.fr (Postfix) with ESMTP id D15C27577; Wed, 17 Jun 2020 23:15:38 +0200 (CEST) Received: from isis.lip6.fr (isis.lip6.fr [132.227.60.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by systeme.lip6.fr (Postfix) with ESMTPS id 5663E3D0F for ; Wed, 17 Jun 2020 23:15:37 +0200 (CEST) Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr [192.134.164.104]) by isis.lip6.fr (8.15.2/8.15.2) with ESMTPS id 05HLFaaf009755 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 17 Jun 2020 23:15:36 +0200 (CEST) X-IronPort-AV: E=Sophos;i="5.73,523,1583190000"; d="scan'208";a="351907740" Received: from abo-173-121-68.mrs.modulonet.fr (HELO hadrien) ([85.68.121.173]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jun 2020 23:15:36 +0200 Date: Wed, 17 Jun 2020 23:15:36 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Johannes Berg In-Reply-To: <812b3a31097815244e0f929552819ac1f119f5a0.camel@sipsolutions.net> Message-ID: References: <812b3a31097815244e0f929552819ac1f119f5a0.camel@sipsolutions.net> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 X-Greylist: Sender IP whitelisted, Sender e-mail whitelisted, not delayed by milter-greylist-4.4.3 (isis.lip6.fr [132.227.60.2]); Wed, 17 Jun 2020 23:15:39 +0200 (CEST) X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.4.3 (isis.lip6.fr [132.227.60.2]); Wed, 17 Jun 2020 23:15:36 +0200 (CEST) X-Scanned-By: MIMEDefang 2.78 on 132.227.60.2 X-Scanned-By: MIMEDefang 2.78 on 132.227.60.2 Cc: cocci@systeme.lip6.fr Subject: Re: [Cocci] moving variable declarations up X-BeenThere: cocci@systeme.lip6.fr X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: cocci-bounces@systeme.lip6.fr Errors-To: cocci-bounces@systeme.lip6.fr On Wed, 17 Jun 2020, Johannes Berg wrote: > Hi spatchers, > > I've been working on an old code base, and toying with something like > this: > > @@ > type T; > identifier x; > expression E, F; > @@ > { > +T x; Change the + to ++ There is no guarantee on the order in which the variables will appear. > + > E; > ... Add when any after the ... julia > -T x; > ... > } > > (and also a variant with "T x = F;" where F is an expression). > > > That works OK if there's only a single variable, but... > > First, it only moves a single variable up, even if I run it multiple > times (I think)? > > Secondly, sometimes it says something like: > > previous modification: > > <<< T x; > > CONTEXT > According to environment 2: > rule starting on line 15.x -> id var1 > rule starting on line 15.T -> u32 > > current modification: > > <<< T x; > > CONTEXT > According to environment 2: > rule starting on line 15.x -> id var2 > rule starting on line 15.T -> u32 > > EXN:Failure("rule starting on line 15: already tagged token:\nC code context\nFile \"/tmp/cocci_small_output-170001-6edb7c.c\", line 150, column 4, charpos = 8969\n around = 'DEBUG_PRINT', whole content = DEBUG_PRINT(...omitted...);") > > > That's basically what I saw, something like > > DEBUG_PRINT(...); > u32 var1 = ...; > u32 var2 = ...; > > > Any ideas how I can make it move more variable declarations up? > > Thanks, > johannes > > _______________________________________________ > Cocci mailing list > Cocci@systeme.lip6.fr > https://systeme.lip6.fr/mailman/listinfo/cocci > _______________________________________________ Cocci mailing list Cocci@systeme.lip6.fr https://systeme.lip6.fr/mailman/listinfo/cocci