Re: [cocci] Broken code block size determination in function implementations

[Markus Elfring <Markus.Elfring@web.de>]

> OK, that was much more understandable. …

I would like to add another development idea.


@initialize:python@
@@
import sys

records = {}

def store_data(places):
    """Add source code positions to an internal table."""
    for place in places:
       key = place.file, place.line, int(place.column) + 1

       if key in records:
          value = records[key]
          actions = value[0]
          actions.append(place.current_element)
          records[key] = actions, value[1]
       else:
          records[key] = [place.current_element], str(int(place.current_element_line_end) - int(place.line) - 1)


@searching@
identifier f;
position p;
@@
 f(...)
 {@p
 ...
 }

@script:python collection@
place << searching.p;
@@
store_data(place)

@finalize:python@
@@
if len(records) > 0:
   delimiter = "|"
   sys.stdout.write(delimiter.join(['action',
                                    '"block size"',
                                    '"source file"',
                                    '"block start line"',
                                    '"block start column"'
                                    ]))
   sys.stdout.write("\n")

   for key, value in records.items():
      sys.stdout.write(delimiter.join([str(value[0]),
                                       str(value[1]),
                                       key[0],
                                       key[1],
                                       str(key[2])
                                      ]))
      sys.stdout.write("\n")
else:
   sys.stderr.write("No result for this analysis!\n")


Test result:
Markus_Elfring@Sonne:…/Projekte/Linux/next-analyses> time spatch --python /usr/bin/python3 …/Projekte/Coccinelle/janitor/list_curly_bracket_positions_for_function_implementations7.cocci arch/sh/drivers/pci/common.c
…
action|"block size"|"source file"|"block start line"|"block start column"
['early_read_config_byte', 'early_read_config_dword', 'early_read_config_word', 'early_write_config_byte', 'early_write_config_dword', 'early_write_config_word']|3|arch/sh/drivers/pci/common.c|36|1
['fake_pci_dev']|17|arch/sh/drivers/pci/common.c|13|1
…
real    0m0,164s
user    0m0,133s
sys     0m0,028s


Would you be looking for more powerful computation resources if you would dare
to repeat the shown source code analysis approach with parallel data processing
on all Linux source files occasionally?

Would you become curious to take another look at the software run time characteristics
according to the biggest function implementations (which can be found also
by the means of the semantic patch language)?

Regards,
Markus