Re: [cocci] Broken code block size determination in function implementations

[Markus Elfring <Markus.Elfring@web.de>]

> Coccinelle doesn't report on parse errors unless an option like
> --verbose-parsing or --parse-c is provided.

How helpful do you find the following information then?


Markus_Elfring@Sonne:…/Projekte/Linux/next-analyses> spatch --verbose-parsing …/Projekte/Coccinelle/janitor/list_curly_bracket_positions_for_function_implementations4.cocci arch/sh/drivers/pci/common.c
…
HANDLING: arch/sh/drivers/pci/common.c
ERROR-RECOV: found sync col 0 at line 49
parsing pass2: try again
ERROR-RECOV: found sync col 0 at line 49
parsing pass3: try again
Warning: PARSING: arch/sh/drivers/pci/common.c:34: two or more data types: dropping int
, keeping typeD __init

; value = ([0], [0], [(0, 0, (Tag9 ((["__init"; (Tag2 (("__init", 736, 34, 4, "arch/sh/drivers/pci/common.c"), (("\n", 983, 41, 0, "arch/sh/drivers/pci/common.c"), 4)), (0), ((0, 0, 0, 0)), 0, (3))]), 0)))], [(0, 0, 0)], [0])
Warning: PARSING: arch/sh/drivers/pci/common.c:34: two or more data types: dropping int
, keeping typeD __init

; value = ([0], [0], [(0, 0, (Tag9 ((["__init"; (Tag2 (("__init", 736, 34, 4, "arch/sh/drivers/pci/common.c"), (("\n", 1014, 42, 30, "arch/sh/drivers/pci/common.c"), 4)), (0), ((0, 0, 0, 0)), 0, (3))]), 0)))], [(0, 0, 0)], [0])
Warning: PARSING: arch/sh/drivers/pci/common.c:34: two or more data types: dropping int
, keeping typeD __init

; value = ([0], [0], [(0, 0, (Tag9 ((["__init"; (Tag2 (("__init", 736, 34, 4, "arch/sh/drivers/pci/common.c"), (("\n", 1046, 43, 31, "arch/sh/drivers/pci/common.c"), 4)), (0), ((0, 0, 0, 0)), 0, (3))]), 0)))], [(0, 0, 0)], [0])
Warning: PARSING: arch/sh/drivers/pci/common.c:34: two or more data types: dropping int
, keeping typeD __init

; value = ([0], [0], [(0, 0, (Tag9 ((["__init"; (Tag2 (("__init", 736, 34, 4, "arch/sh/drivers/pci/common.c"), (("\n", 1079, 44, 32, "arch/sh/drivers/pci/common.c"), 4)), (0), ((0, 0, 0, 0)), 0, (3))]), 0)))], [(0, 0, 0)], [0])
Warning: PARSING: arch/sh/drivers/pci/common.c:34: two or more data types: dropping int
, keeping typeD __init

; value = ([0], [0], [(0, 0, (Tag9 ((["__init"; (Tag2 (("__init", 736, 34, 4, "arch/sh/drivers/pci/common.c"), (("\n", 1109, 45, 29, "arch/sh/drivers/pci/common.c"), 4)), (0), ((0, 0, 0, 0)), 0, (3))]), 0)))], [(0, 0, 0)], [0])
Warning: PARSING: arch/sh/drivers/pci/common.c:34: two or more data types: dropping int
, keeping typeD __init

; value = ([0], [0], [(0, 0, (Tag9 ((["__init"; (Tag2 (("__init", 736, 34, 4, "arch/sh/drivers/pci/common.c"), (("\n", 1140, 46, 30, "arch/sh/drivers/pci/common.c"), 4)), (0), ((0, 0, 0, 0)), 0, (3))]), 0)))], [(0, 0, 0)], [0])
-> duplicate data
file:
arch/sh/drivers/pci/common.c
function:
early_read_config_dword
line:
36
…



Markus_Elfring@Sonne:…/Projekte/Linux/next-analyses> spatch --parse-c arch/sh/drivers/pci/common.c
…
NB total files = 1; perfect = 1; pbs = 0; timeout = 0; =========> 100%
nb good = 159,  nb passed = 6 =========> 3.64% passed
nb good = 159,  nb bad = 0 =========> 100.00% good or passed


Regards,
Markus