From: Tobias Deiminger <tobias.deiminger@posteo.de>
To: cocci@inria.fr
Subject: Re: [cocci] Can we match a known macro by macro name instead of expanded function name?
Date: Mon, 01 Dec 2025 08:32:23 +0000 [thread overview]
Message-ID: <febfffa409763a47d12b330fa455c927@posteo.de> (raw)
In-Reply-To: <893abd46009f5e07e55f6b3f36645eda@posteo.de>
Am 30.11.2025 20:02 schrieb Tobias Deiminger:
>>> and then do 'type t =~ "syscall_define_t";' in the rule.
>>
>> I would like to point out that mentioned implementation details can be
>> refined.
>> I suggest to reconsider the need for the specification of an SmPL
>> constraint
>> as a regular expression just for the selection of a single identifier.
>
> Indeed, thanks! Selecting a specific type in the semantic patch didn't
> work on first try. Meanwhile I figured one needs to add a typedef to
> the meta declaration - then it works and I can avoid the regex.
Sadly, what I said above (adding typedef) only works when calling spatch
for one specific .c file. It fails when using --dir to recursively scan
the source tree.
What seems to happen with --dir and using the following rule
@r@
typedef syscall_define_t;
identifier fn;
@@
syscall_define_t fn(...) {...}
is that spatch filters .c files early by raw text search for
"syscall_define_t", before it actually processes patterns. In my case,
"syscall_define_t" is not written to .c, but to the built-in macro file.
The raw text search in .c fails, and the .c file is wrongly filtered
out.
To verify my hypothesis, simply adding a comment line "//
syscall_define_t" to the .c file is enough to trick spatch into not
skipping the file and applying the rule correctly.
This almost appears like a bug. Can you think of a workaround?
Tobias
next prev parent reply other threads:[~2025-12-01 8:32 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-29 10:38 [cocci] Can we match a known macro by macro name instead of expanded function name? Tobias Deiminger
2025-11-29 10:56 ` Julia Lawall
2025-11-29 13:15 ` Tobias Deiminger
2025-11-29 13:32 ` Markus Elfring
2025-11-29 13:51 ` Julia Lawall
2025-11-29 14:51 ` Markus Elfring
2025-11-29 15:00 ` Julia Lawall
2025-11-29 15:10 ` [cocci] Questionable macro expansions Markus Elfring
2025-11-29 15:55 ` [cocci] Can we match a known macro by macro name instead of expanded function name? Tobias Deiminger
2025-11-29 15:59 ` Julia Lawall
[not found] ` <67d1e00d2e22a4655cb10ec55d1a99db@posteo.de>
[not found] ` <83c8a7aa-9b98-8ac1-d563-e8fe2588f9a@inria.fr>
[not found] ` <fd7307f8024706d4bd128d0b7f43bb96@posteo.de>
2025-11-29 17:33 ` Tobias Deiminger
2025-11-29 17:38 ` Markus Elfring
2025-11-29 17:59 ` Julia Lawall
2025-11-29 18:28 ` Markus Elfring
2025-11-29 18:41 ` Julia Lawall
2025-11-29 19:00 ` Markus Elfring
2025-11-29 20:06 ` Tobias Deiminger
2025-11-29 20:10 ` Julia Lawall
2025-11-30 8:44 ` [cocci] Clarification for parsing capabilities? Markus Elfring
2025-11-30 8:05 ` [cocci] Can we match a known macro by macro name instead of expanded function name? Markus Elfring
2025-11-30 19:02 ` Tobias Deiminger
2025-12-01 8:32 ` Tobias Deiminger [this message]
2025-12-01 14:00 ` Markus Elfring
2025-12-01 9:42 ` Markus Elfring
2025-12-04 8:50 ` [cocci] Searching for system call implementations? Markus Elfring
2025-11-29 16:28 ` [cocci] Can we match a known macro by macro name instead of expanded function name? Markus Elfring
2025-12-02 9:45 ` [cocci] Searching for system call implementations with SmPL? Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=febfffa409763a47d12b330fa455c927@posteo.de \
--to=tobias.deiminger@posteo.de \
--cc=cocci@inria.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox