public inbox for connman@lists.linux.dev
 help / color / mirror / Atom feed
* [PATCH] client: Add missing newlines on error messages
@ 2025-07-03 18:48 jaeyoon.jung
  0 siblings, 0 replies; 3+ messages in thread
From: jaeyoon.jung @ 2025-07-03 18:48 UTC (permalink / raw)
  To: connman; +Cc: Jaeyoon Jung

From: Jaeyoon Jung <jaeyoon.jung@lge.com>

This adds missing newlines at the end of some error messages.
---
 client/commands.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/client/commands.c b/client/commands.c
index 53cc14c8..376ccdb5 100644
--- a/client/commands.c
+++ b/client/commands.c
@@ -1874,7 +1874,7 @@ static int session_create_cb(DBusMessageIter *iter, int errnum,
 	char *str;
 
 	if (error) {
-		fprintf(stderr, "Error creating session: %s", error);
+		fprintf(stderr, "Error creating session: %s\n", error);
 		session_notify_remove();
 		return 0;
 	}
@@ -2044,7 +2044,7 @@ static int session_destroy_cb(DBusMessageIter *iter, int errnum,
 			const char *error, void *user_data)
 {
 	if (error) {
-		fprintf(stderr, "Error destroying session: %s", error);
+		fprintf(stderr, "Error destroying session: %s\n", error);
 		return 0;
 	}
 
@@ -3026,7 +3026,7 @@ static int populate_service_hash(DBusMessageIter *iter, int errnum,
 				const char *error, void *user_data)
 {
 	if (error) {
-		fprintf(stderr, "Error getting services: %s", error);
+		fprintf(stderr, "Error getting services: %s\n", error);
 		return 0;
 	}
 
@@ -3086,7 +3086,7 @@ static int populate_vpnconnection_hash(DBusMessageIter *iter, int errnum,
 	DBusMessageIter array;
 
 	if (error) {
-		fprintf(stderr, "Error getting VPN connections: %s", error);
+		fprintf(stderr, "Error getting VPN connections: %s\n", error);
 		return 0;
 	}
 
@@ -3158,7 +3158,7 @@ static int populate_peer_hash(DBusMessageIter *iter, int errnum,
 			const char *error, void *user_data)
 {
 	if (error) {
-		fprintf(stderr, "Error getting peers: %s", error);
+		fprintf(stderr, "Error getting peers: %s\n", error);
 		return 0;
 	}
 
-- 
2.47.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread
* [PATCH] client: Add missing newlines on error messages
@ 2025-07-03 19:13 jaeyoon.jung
  2025-07-09 17:40 ` patchwork-bot+connman
  0 siblings, 1 reply; 3+ messages in thread
From: jaeyoon.jung @ 2025-07-03 19:13 UTC (permalink / raw)
  To: connman; +Cc: Jaeyoon Jung

From: Jaeyoon Jung <jaeyoon.jung@lge.com>

This adds missing newlines at the end of some error messages.
---
 client/commands.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/client/commands.c b/client/commands.c
index 53cc14c8..376ccdb5 100644
--- a/client/commands.c
+++ b/client/commands.c
@@ -1874,7 +1874,7 @@ static int session_create_cb(DBusMessageIter *iter, int errnum,
 	char *str;
 
 	if (error) {
-		fprintf(stderr, "Error creating session: %s", error);
+		fprintf(stderr, "Error creating session: %s\n", error);
 		session_notify_remove();
 		return 0;
 	}
@@ -2044,7 +2044,7 @@ static int session_destroy_cb(DBusMessageIter *iter, int errnum,
 			const char *error, void *user_data)
 {
 	if (error) {
-		fprintf(stderr, "Error destroying session: %s", error);
+		fprintf(stderr, "Error destroying session: %s\n", error);
 		return 0;
 	}
 
@@ -3026,7 +3026,7 @@ static int populate_service_hash(DBusMessageIter *iter, int errnum,
 				const char *error, void *user_data)
 {
 	if (error) {
-		fprintf(stderr, "Error getting services: %s", error);
+		fprintf(stderr, "Error getting services: %s\n", error);
 		return 0;
 	}
 
@@ -3086,7 +3086,7 @@ static int populate_vpnconnection_hash(DBusMessageIter *iter, int errnum,
 	DBusMessageIter array;
 
 	if (error) {
-		fprintf(stderr, "Error getting VPN connections: %s", error);
+		fprintf(stderr, "Error getting VPN connections: %s\n", error);
 		return 0;
 	}
 
@@ -3158,7 +3158,7 @@ static int populate_peer_hash(DBusMessageIter *iter, int errnum,
 			const char *error, void *user_data)
 {
 	if (error) {
-		fprintf(stderr, "Error getting peers: %s", error);
+		fprintf(stderr, "Error getting peers: %s\n", error);
 		return 0;
 	}
 
-- 
2.47.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH] client: Add missing newlines on error messages
  2025-07-03 19:13 [PATCH] client: Add missing newlines on error messages jaeyoon.jung
@ 2025-07-09 17:40 ` patchwork-bot+connman
  0 siblings, 0 replies; 3+ messages in thread
From: patchwork-bot+connman @ 2025-07-09 17:40 UTC (permalink / raw)
  To: None; +Cc: connman

Hello:

This patch was applied to connman.git (master)
by Denis Kenzior <denkenz@gmail.com>:

On Fri,  4 Jul 2025 04:13:44 +0900 you wrote:
> From: Jaeyoon Jung <jaeyoon.jung@lge.com>
> 
> This adds missing newlines at the end of some error messages.
> ---
>  client/commands.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)

Here is the summary with links:
  - client: Add missing newlines on error messages
    https://git.kernel.org/pub/scm/network/connman/connman.git/?id=d1e56402d8cc

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-07-09 17:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-03 19:13 [PATCH] client: Add missing newlines on error messages jaeyoon.jung
2025-07-09 17:40 ` patchwork-bot+connman
  -- strict thread matches above, loose matches on Subject: below --
2025-07-03 18:48 jaeyoon.jung

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox