[PATCH 1/2] wispr: Ensure memory cleaned up in all cases

[Ed Rose | Tewke <ed@tewke.com>]

If `connman_proxy_lookup` fails to resolve a proxy, the code path fails
to unref the `connman_wispr_portal_context` resulting in a resource
leak of both memory and file descriptors. This can lead to connman
hitting it's OS fd limit and becoming non-functional.

Resolve this by ensuring the reference count for the portal context is
always decremented, even in error cases.
---
 src/wispr.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/wispr.c b/src/wispr.c
index a40cf353..a8e16b7e 100644
--- a/src/wispr.c
+++ b/src/wispr.c
@@ -1303,7 +1303,7 @@ static void proxy_callback(const char *proxy, void *user_data)

 		portal_manage_failure_status(wp_context, 0, "no valid proxy");

-		return;
+		goto done;
 	}

 	DBG("proxy %s", proxy);
@@ -1328,6 +1328,7 @@ static void proxy_callback(const char *proxy, void *user_data)
 					xml_wispr_parser_callback, wp_context);

 	wispr_portal_request_portal(wp_context);
+done:
 	wispr_portal_context_unref(wp_context);
 }

--
2.43.0