Re: [PATCH 17/45] vpn-util: Add wrappers for GResolv hostname lookup use

[Denis Kenzior <denkenz@gmail.com>]

Hi Jussi,

On 8/8/25 7:36 AM, Jussi Laakkonen wrote:
> Hi Denis,
> 
> On 8/4/25 17:39, Denis Kenzior wrote:
>> Hi Jussi,
>>
>> On 7/11/25 9:27 AM, Jussi Laakkonen wrote:
>>> To avoid linking GResolv with every VPN plugin that uses it, add wrappers
>>> for the required calls in VPN utils.
>>
>> This may need a bit more explanation?  You're still using GResolv types in 
>> these functions?  Why can't g_resolv_ be used instead?
> 
> I can amend the commit message on this. The issue is that VPN plugins can be 
> either builtin, external (or out of code tree plugins), so making this wrapper 
> is a bit more straightforward by linking vpnd only with gresolv and having the 
> plugins not to care about it?

 From a maintenance stand point this is not preferable.  Why would we maintain 
extra wrappers for a library that is in-tree and we control in the first place? 
The plugins should link against GResolv and any issues should be solved at the 
build system level.

Regards,
-Denis