Linux Container Development
 help / color / mirror / Atom feed
From: "Denis V. Lunev" <den@openvz.org>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, devel@openvz.org,
	containers@lists.osdl.org, "Denis V. Lunev" <den@openvz.org>
Subject: [PATCH 2/12 net-2.6.25] [IPV4]: Consolidate fib_select_default.
Date: Tue, 22 Jan 2008 18:59:19 +0300	[thread overview]
Message-ID: <1201017566-16985-2-git-send-email-den@openvz.org> (raw)
In-Reply-To: <479612BE.8030409@openvz.org>

The difference in the implementation of the fib_select_default when
CONFIG_IP_MULTIPLE_TABLES is (not) defined looks negligible. Consolidate it
and place into fib_frontend.c.

Signed-off-by: Denis V. Lunev <den@openvz.org>
---
 include/net/ip_fib.h    |   10 +---------
 net/ipv4/fib_frontend.c |   14 ++++++++++++++
 net/ipv4/fib_rules.c    |   10 ----------
 3 files changed, 15 insertions(+), 19 deletions(-)

diff --git a/include/net/ip_fib.h b/include/net/ip_fib.h
index be70b33..39f944a 100644
--- a/include/net/ip_fib.h
+++ b/include/net/ip_fib.h
@@ -193,14 +193,6 @@ static inline int fib_lookup(struct net *net, const struct flowi *flp,
 	return -ENETUNREACH;
 }
 
-static inline void fib_select_default(const struct flowi *flp,
-				      struct fib_result *res)
-{
-	struct fib_table *table = fib_get_table(&init_net, RT_TABLE_MAIN);
-	if (FIB_RES_GW(*res) && FIB_RES_NH(*res).nh_scope == RT_SCOPE_LINK)
-		table->tb_select_default(table, flp, res);
-}
-
 #else /* CONFIG_IP_MULTIPLE_TABLES */
 extern int __net_init fib4_rules_init(struct net *net);
 extern void __net_exit fib4_rules_exit(struct net *net);
@@ -213,7 +205,6 @@ extern int fib_lookup(struct net *n, struct flowi *flp, struct fib_result *res);
 
 extern struct fib_table *fib_new_table(struct net *net, u32 id);
 extern struct fib_table *fib_get_table(struct net *net, u32 id);
-extern void fib_select_default(const struct flowi *flp, struct fib_result *res);
 
 #endif /* CONFIG_IP_MULTIPLE_TABLES */
 
@@ -222,6 +213,7 @@ extern const struct nla_policy rtm_ipv4_policy[];
 extern void		ip_fib_init(void);
 extern int fib_validate_source(__be32 src, __be32 dst, u8 tos, int oif,
 			       struct net_device *dev, __be32 *spec_dst, u32 *itag);
+extern void fib_select_default(const struct flowi *flp, struct fib_result *res);
 
 /* Exported by fib_semantics.c */
 extern int ip_fib_check_default(__be32 gw, struct net_device *dev);
diff --git a/net/ipv4/fib_frontend.c b/net/ipv4/fib_frontend.c
index 6761639..13bf01d 100644
--- a/net/ipv4/fib_frontend.c
+++ b/net/ipv4/fib_frontend.c
@@ -116,6 +116,20 @@ struct fib_table *fib_get_table(struct net *net, u32 id)
 }
 #endif /* CONFIG_IP_MULTIPLE_TABLES */
 
+void fib_select_default(const struct flowi *flp, struct fib_result *res)
+{
+	struct fib_table *tb;
+	int table = RT_TABLE_MAIN;
+#ifdef CONFIG_IP_MULTIPLE_TABLES
+	if (res->r == NULL || res->r->action != FR_ACT_TO_TBL)
+		return;
+	table = res->r->table;
+#endif
+	tb = fib_get_table(&init_net, table);
+	if (FIB_RES_GW(*res) && FIB_RES_NH(*res).nh_scope == RT_SCOPE_LINK)
+		tb->tb_select_default(tb, flp, res);
+}
+
 static void fib_flush(struct net *net)
 {
 	int flushed = 0;
diff --git a/net/ipv4/fib_rules.c b/net/ipv4/fib_rules.c
index 1effb4a..19274d0 100644
--- a/net/ipv4/fib_rules.c
+++ b/net/ipv4/fib_rules.c
@@ -102,16 +102,6 @@ errout:
 }
 
 
-void fib_select_default(const struct flowi *flp, struct fib_result *res)
-{
-	if (res->r && res->r->action == FR_ACT_TO_TBL &&
-	    FIB_RES_GW(*res) && FIB_RES_NH(*res).nh_scope == RT_SCOPE_LINK) {
-		struct fib_table *tb;
-		if ((tb = fib_get_table(&init_net, res->r->table)) != NULL)
-			tb->tb_select_default(tb, flp, res);
-	}
-}
-
 static int fib4_rule_match(struct fib_rule *rule, struct flowi *fl, int flags)
 {
 	struct fib4_rule *r = (struct fib4_rule *) rule;
-- 
1.5.3.rc5


  parent reply	other threads:[~2008-01-22 15:59 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-22 15:58 [PATCH 0/12 net-2.6.25] [NETNS]: Routing namespacing on IP output path Denis V. Lunev
2008-01-22 15:59 ` [PATCH 1/12 net-2.6.25] [IPV4]: Declarations cleanup in ip_fib.h Denis V. Lunev
2008-01-22 15:59 ` Denis V. Lunev [this message]
2008-01-22 15:59 ` [PATCH 3/12 net-2.6.25] [NETNS]: Add netns parameter to fib_select_default Denis V. Lunev
2008-01-22 15:59 ` [PATCH 4/12 net-2.6.25] [NETNS]: Add namespace parameter to ip_dev_find Denis V. Lunev
2008-01-22 15:59 ` [PATCH 5/12 net-2.6.25] [NETNS]: Re-export init_net via EXPORT_SYMBOL Denis V. Lunev
2008-01-22 17:04   ` Patrick McHardy
2008-01-22 17:19     ` Denis V. Lunev
2008-01-23  6:08       ` David Miller
2008-01-22 15:59 ` [PATCH 6/12 net-2.6.25] [NETNS]: Add namespace parameter to ip_route_output_slow Denis V. Lunev
2008-01-22 15:59 ` [PATCH 7/12 net-2.6.25] [NETNS]: Add namespace parameter to __ip_route_output_key Denis V. Lunev
2008-01-22 15:59 ` [PATCH 8/12 net-2.6.25] [NETNS]: Add namespace parameter to ip_route_output_flow Denis V. Lunev
2008-01-22 15:59 ` [PATCH 9/12 net-2.6.25] [NETNS]: Add namespace parameter to ip_route_output_key Denis V. Lunev
2008-01-23  6:09 ` [PATCH 0/12 net-2.6.25] [NETNS]: Routing namespacing on IP output path David Miller
2008-01-23  7:46 ` [PATCH 10/12 net-2.6.25] [NETNS]: Correct namespace for connect-time routing Denis V. Lunev
2008-01-23  7:51   ` David Miller
2008-01-23  7:46 ` [PATCH 11/12 net-2.6.25] [NETNS]: Routing cache virtualization Denis V. Lunev
2008-01-23  7:51   ` David Miller
2008-01-23  7:46 ` [PATCH 12/12 net-2.6.25] [NETNS]: Add namespace for ICMP replying code Denis V. Lunev
2008-01-23  7:51   ` David Miller
     [not found]     ` <20080122.235130.84789113.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2008-01-23  9:16       ` Mathieu Lacage
2008-01-23  9:30         ` YOSHIFUJI Hideaki / 吉藤英明

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1201017566-16985-2-git-send-email-den@openvz.org \
    --to=den@openvz.org \
    --cc=containers@lists.osdl.org \
    --cc=davem@davemloft.net \
    --cc=devel@openvz.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox