Linux Container Development
 help / color / mirror / Atom feed
From: "Denis V. Lunev" <den@openvz.org>
To: David Miller <davem@davemloft.net>
Cc: yoshfuji@linux-ipv6.org, netdev@vger.kernel.org,
	containers@lists.osdl.org
Subject: Re: [PATCH 0/3 net-2.6.26] Compilation fixes.
Date: Thu, 03 Apr 2008 01:00:07 +0400	[thread overview]
Message-ID: <1207170007.7118.6.camel@iris.sw.ru> (raw)
In-Reply-To: <20080402.135609.145425148.davem@davemloft.net>

On Wed, 2008-04-02 at 13:56 -0700, David Miller wrote:
> From: "Denis V. Lunev" <den@openvz.org>
> Date: Wed, 02 Apr 2008 23:46:19 +0400
> 
> > On Wed, 2008-04-02 at 11:42 -0700, David Miller wrote:
> > > From: "Denis V. Lunev" <den@openvz.org>
> > > Date: Wed, 02 Apr 2008 14:01:14 +0400
> > > 
> > > > Dave, could you pls conside this addition. This should fix problem
> > > > reported by the Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> recently.
> > > 
> > > Then this invalidates enourmous amounts of CONFIG_NET tests
> > > we've put into the headers over the past few days. 
> > > 
> > > All of them were explicitly to avoid having to provide the
> > > init_net symbol when CONFIG_NET is not set.
> > 
> > OK. do you suggest to insert another CONFIG_NET check into if_pppox
> > header or separate fs/compat_ioctl.c into two files:
> > - for net ioctls
> > - for the rest?
> 
> It's probably better to go your route.  That is, unprotect
> the init_net extern, and remove the CONFIG_NET's we added
> which are no longer necessary.
> 
> Could you do such a patch set?  Thanks.

Sure, but, unfortunately, only tomorrow morning. It is too late today in
Moscow :)


  reply	other threads:[~2008-04-02 21:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-31 15:46 [PATCH 0/3 net-2.6.26] Compilation fixes Denis V. Lunev
2008-03-31 15:47 ` [PATCH 1/3 net-2.6.26] [NETNS]: Merge ifdef CONFIG_NET in include/net/net_namespace.h Denis V. Lunev
2008-03-31 15:47 ` [PATCH 2/3 net-2.6.26] [NETNS]: Remove ifdef CONFIG_NET braces in fs/proc/proc_net.c Denis V. Lunev
2008-03-31 15:47 ` [PATCH 3/3 net-2.6.26] [NETNS]: Do not include net/net_namespace.h from seq_file.h Denis V. Lunev
2008-04-02  7:10 ` [PATCH 0/3 net-2.6.26] Compilation fixes David Miller
2008-04-02 10:01   ` Denis V. Lunev
2008-04-02 18:42     ` David Miller
2008-04-02 19:46       ` Denis V. Lunev
2008-04-02 20:56         ` David Miller
2008-04-02 21:00           ` Denis V. Lunev [this message]
2008-04-02 21:00             ` David Miller
2008-04-03 14:13               ` Denis V. Lunev
2008-04-03 20:25                 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1207170007.7118.6.camel@iris.sw.ru \
    --to=den@openvz.org \
    --cc=containers@lists.osdl.org \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox