From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Hansen Subject: Re: [PATCH -mm 1/5] swapcgroup (v3): add cgroup files Date: Thu, 10 Jul 2008 13:35:36 -0700 Message-ID: <1215722136.9398.59.camel@nimitz> References: <20080704151536.e5384231.nishimura@mxp.nes.nec.co.jp> <20080704151747.470d62a3.nishimura@mxp.nes.nec.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20080704151747.470d62a3.nishimura-YQH0OdQVrdy45+QrQBaojngSJqDPrsil@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Daisuke Nishimura Cc: YAMAMOTO Takashi , Linux MM , KOSAKI Motohiro , Linux Containers , Hugh Dickins , Pavel Emelyanov , Balbir Singh List-Id: containers.vger.kernel.org On Fri, 2008-07-04 at 15:17 +0900, Daisuke Nishimura wrote: > +config CGROUP_SWAP_RES_CTLR > + bool "Swap Resource Controller for Control Groups" > + depends on CGROUP_MEM_RES_CTLR && SWAP > + help > + Provides a swap resource controller that manages and limits swap usage. > + Implemented as a add-on to Memory Resource Controller. Could you make this just plain depend on 'CGROUP_MEM_RES_CTLR && SWAP' and not make it configurable? I don't think the resource usage really justifies yet another .config knob to tune and break. :) -- Dave