From: Dan Smith <danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org
Subject: [PATCH 1/2] Add UTS support to mktree (v4)
Date: Wed, 18 Mar 2009 11:55:09 -0700 [thread overview]
Message-ID: <1237402510-29053-2-git-send-email-danms@us.ibm.com> (raw)
In-Reply-To: <1237402510-29053-1-git-send-email-danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Read the namespace records from the restore stream and do the unshare()
necessary to create a new namespace. For UTS, set hostname and domainname
to match what was stored in the checkpoint.
Changes:
- Check return of sethostname() and setdomainname()
- Update to match new struct name and header type to kernel patch
- Update the method used to read the node and domain names to match
what the updated kernel patch is doing
Signed-off-by: Dan Smith <danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
---
mktree.c | 120 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
1 files changed, 120 insertions(+), 0 deletions(-)
diff --git a/mktree.c b/mktree.c
index 55149dd..fcfa779 100644
--- a/mktree.c
+++ b/mktree.c
@@ -14,6 +14,7 @@
#include <unistd.h>
#include <errno.h>
#include <signal.h>
+#include <sched.h>
#include <sys/types.h>
#include <sys/wait.h>
#include <asm/unistd.h>
@@ -98,9 +99,11 @@ static int cr_write_tree(struct cr_ctx *ctx);
static int cr_read(int fd, void *buf, int count);
static int cr_read_obj(struct cr_ctx *ctx, struct cr_hdr *h, void *buf, int n);
static int cr_read_obj_type(struct cr_ctx *ctx, void *buf, int n, int type);
+static int cr_read_string(struct cr_ctx *ctx, char **buf, int len);
static int cr_read_head(struct cr_ctx *ctx);
static int cr_read_head_arch(struct cr_ctx *ctx);
+static int cr_read_namespaces(struct cr_ctx *ctx);
static int cr_read_tree(struct cr_ctx *ctx);
struct pid_swap {
@@ -191,6 +194,12 @@ int main(int argc, char *argv[])
exit(1);
}
+ ret = cr_read_namespaces(&ctx);
+ if (ret < 0) {
+ perror("read c/r namespaces");
+ exit(1);
+ }
+
ret = cr_fork_feeder(&ctx);
if (ret < 0)
exit(1);
@@ -511,6 +520,30 @@ static int cr_read_obj_type(struct cr_ctx *ctx, void *buf, int n, int type)
return ret;
}
+static int cr_read_string(struct cr_ctx *ctx, char **buf, int len)
+{
+ struct cr_hdr *h = (struct cr_hdr *) ctx->buf;
+ int ret;
+
+ ret = cr_read(STDIN_FILENO, h, sizeof(*h));
+ if (ret < 0)
+ return ret;
+ if (h->type != CR_HDR_STRING)
+ return -1;
+
+ *buf = (char *) malloc(len);
+ if (!*buf)
+ return -ENOMEM;
+
+ ret = cr_read(STDIN_FILENO, *buf, len);
+ if (ret < 0) {
+ free(*buf);
+ *buf = NULL;
+ }
+
+ return ret;
+}
+
/*
* read/write the checkpoint image: similar to in-kernel code
*/
@@ -557,6 +590,93 @@ static int cr_read_head_arch(struct cr_ctx *ctx)
return 0;
}
+static int cr_read_task_utsns(struct cr_ctx *ctx)
+{
+ int parent;
+ struct cr_hdr_utsns hh;
+ char *namebuf = NULL;
+ int ret = 0;
+
+ parent = cr_read_obj_type(ctx, &hh, sizeof(hh),
+ CR_HDR_UTSNS);
+ if (parent < 0)
+ return parent;
+ else if (parent != 0) {
+ errno = -EINVAL;
+ return -1;
+ }
+
+ ret = cr_read_string(ctx, &namebuf, hh.nodename_len);
+ if (ret < 0)
+ goto out;
+
+ if (sethostname(namebuf, strlen(namebuf)) < 0) {
+ perror("sethostname");
+ goto out;
+ }
+
+ free(namebuf);
+ namebuf = NULL;
+
+ ret = cr_read_string(ctx, &namebuf, hh.domainname_len);
+ if (ret < 0)
+ goto out;
+
+ if (setdomainname(namebuf, strlen(namebuf)) < 0)
+ perror("setdomainname");
+ out:
+ free(namebuf);
+
+ return 0;
+}
+
+static int cr_read_task_namespaces(struct cr_ctx *ctx)
+{
+ struct cr_hdr_namespaces hh;
+ int parent;
+ int ret;
+
+ parent = cr_read_obj_type(ctx, &hh, sizeof(hh), CR_HDR_NS);
+ if (parent < 0)
+ return parent;
+ else if (parent != 0) {
+ errno = -EINVAL;
+ return -1;
+ }
+
+ if (hh.types == 0)
+ return 0;
+
+ if (unshare(CLONE_NEWUTS) != 0) {
+ perror("unshare(CLONE_NEWUTS)");
+ return -1;
+ }
+
+ if (hh.types & CR_NS_UTS) {
+ ret = cr_read_task_utsns(ctx);
+ if (ret < 0)
+ return ret;
+
+ /* Read other namespaces here */
+ }
+
+ return 0;
+}
+
+static int cr_read_namespaces(struct cr_ctx *ctx)
+{
+ int n;
+ int ret = 0;
+
+ for (n = 0; n < ctx->pids_nr; n++) {
+ ret = cr_read_task_namespaces(ctx);
+ if (ret < 0)
+ break;
+ }
+
+ return ret;
+}
+
static int cr_read_tree(struct cr_ctx *ctx)
{
struct cr_hdr *h = (struct cr_hdr *) ctx->buf;
--
1.5.6.3
next prev parent reply other threads:[~2009-03-18 18:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-18 18:55 user-cr: UTS support and test Dan Smith
[not found] ` <1237402510-29053-1-git-send-email-danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-03-18 18:55 ` Dan Smith [this message]
2009-03-18 18:55 ` [PATCH 2/2] Add a simple UTS test program Dan Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1237402510-29053-2-git-send-email-danms@us.ibm.com \
--to=danms-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
--cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox