Linux Container Development
 help / color / mirror / Atom feed
From: Dave Hansen <dave-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
To: Nathan Lynch <ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
Cc: containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org
Subject: Re: [PATCH 3/7] make CONFIG_CHECKPOINT depend on CONFIG_CHECKPOINT_SUPPORT
Date: Wed, 25 Mar 2009 17:39:43 -0700	[thread overview]
Message-ID: <1238027983.8286.441.camel@nimitz> (raw)
In-Reply-To: <1238022166-13422-4-git-send-email-ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>

On Wed, 2009-03-25 at 18:02 -0500, Nathan Lynch wrote:
> 
> diff --git a/checkpoint/Kconfig b/checkpoint/Kconfig
> index e91e0fd..760c450 100644
> --- a/checkpoint/Kconfig
> +++ b/checkpoint/Kconfig
> @@ -1,6 +1,6 @@
>  config CHECKPOINT
>         bool "Enable checkpoint/restart (EXPERIMENTAL)"
> -       depends on (X86_32 || (S390 && 64BIT)) && EXPERIMENTAL
> +       depends on CHECKPOINT_SUPPORT && EXPERIMENTAL
>         help
>           Application checkpoint/restart is the ability to save the
>           state of a running application so that it can later resume

Yeah, this is the right way to do it, very nice.

Could we add a wee little ARCH_ prepend on 'CHECKPOINT_SUPPORT' in
there?  That way, people at least know where to go looking when they
want to find out why it isn't enabled.  

-- Dave

  parent reply	other threads:[~2009-03-26  0:39 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-25 23:02 [PATCH 0/7] checkpoint: Kconfig cleanup, powerpc support Nathan Lynch
     [not found] ` <1238022166-13422-1-git-send-email-ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
2009-03-25 23:02   ` [PATCH 1/7] s390: enable checkpoint support in Kconfig Nathan Lynch
     [not found]     ` <1238022166-13422-2-git-send-email-ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
2009-03-25 23:26       ` Serge E. Hallyn
2009-03-25 23:02   ` [PATCH 2/7] x86: " Nathan Lynch
     [not found]     ` <1238022166-13422-3-git-send-email-ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
2009-03-25 23:26       ` Serge E. Hallyn
2009-03-25 23:02   ` [PATCH 3/7] make CONFIG_CHECKPOINT depend on CONFIG_CHECKPOINT_SUPPORT Nathan Lynch
     [not found]     ` <1238022166-13422-4-git-send-email-ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
2009-03-25 23:26       ` Serge E. Hallyn
2009-03-26  0:39       ` Dave Hansen [this message]
2009-03-26  3:09         ` Nathan Lynch
     [not found]           ` <20090325220931.2653f379-4v5LP+xe+1byhTdZtsIeww@public.gmane.org>
2009-05-12 11:20             ` Ralph-Gordon Paul
     [not found]               ` <FB599A4B-F618-4E6C-94D8-FC4EAE3D41D9-4bfl1RV3iZDOEhgYWvzSCYQuADTiUCJX@public.gmane.org>
2009-05-12 12:10                 ` [PATCH 3/7] make CONFIG_CHECKPOINT depend onCONFIG_CHECKPOINT_SUPPORT Serge E. Hallyn
     [not found]                   ` <20090512121001.GB28695-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-05-12 12:42                     ` Ralph-Gordon Paul
     [not found]                       ` <3A15FE99-C94B-467B-B475-44BBED892C25-4bfl1RV3iZDOEhgYWvzSCYQuADTiUCJX@public.gmane.org>
2009-05-12 14:29                         ` [PATCH 3/7] make CONFIG_CHECKPOINT dependonCONFIG_CHECKPOINT_SUPPORT Serge E. Hallyn
     [not found]                           ` <20090512142912.GA31449-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-05-12 15:16                             ` Oren Laadan
     [not found]                               ` <4A0992CB.9050404-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2009-05-12 15:44                                 ` Serge E. Hallyn
     [not found]                                   ` <20090512154455.GA32658-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-05-12 16:16                                     ` Oren Laadan
     [not found]                                       ` <4A09A0D4.40208-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2009-05-12 16:39                                         ` Serge E. Hallyn
2009-03-25 23:02   ` [PATCH 4/7] powerpc: provide APIs for validating and updating DABR Nathan Lynch
2009-03-25 23:02   ` [PATCH 5/7] powerpc: checkpoint/restart implementation Nathan Lynch
2009-03-25 23:02   ` [PATCH 6/7] powerpc: wire up checkpoint and restart syscalls Nathan Lynch
2009-03-25 23:02   ` [PATCH 7/7] powerpc: enable checkpoint support in Kconfig Nathan Lynch
2009-03-30 14:57   ` [PATCH 0/7] checkpoint: Kconfig cleanup, powerpc support Oren Laadan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1238027983.8286.441.camel@nimitz \
    --to=dave-23vcf4htsmix0ybbhkvfkdbpr1lh4cv8@public.gmane.org \
    --cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
    --cc=ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox