Linux Container Development
 help / color / mirror / Atom feed
From: Dan Smith <danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org
Subject: [PATCH] Fix ckpt_obj_lookup_add() leak detection logic
Date: Thu, 17 Sep 2009 10:07:54 -0700	[thread overview]
Message-ID: <1253207274-7563-1-git-send-email-danms@us.ibm.com> (raw)

Since first is a pointer, it's never NULL and thus leak detection will
always be performed (of CHECKPOINT_SUBTREE is set).  This fatally breaks
the checkpoint process when that flag is enabled because any object (with
a ref_users operation) that is added to the hash twice will be reported as
a reverse leak.

Signed-off-by: Dan Smith <danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
---
 checkpoint/objhash.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/checkpoint/objhash.c b/checkpoint/objhash.c
index 8dfb0b0..b85aa77 100644
--- a/checkpoint/objhash.c
+++ b/checkpoint/objhash.c
@@ -679,7 +679,7 @@ int ckpt_obj_lookup_add(struct ckpt_ctx *ctx, void *ptr,
 	ckpt_debug("%s objref %d first %d\n",
 		   obj->ops->obj_name, obj->objref, *first);
 
-	if (first && obj_reverse_leak(ctx, obj))
+	if (*first && obj_reverse_leak(ctx, obj))
 		return -EBUSY;
 
 	obj->flags |= CKPT_OBJ_VISITED;
-- 
1.6.2.5

             reply	other threads:[~2009-09-17 17:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-17 17:07 Dan Smith [this message]
     [not found] ` <1253207274-7563-1-git-send-email-danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-09-18 17:01   ` [PATCH] Fix ckpt_obj_lookup_add() leak detection logic Oren Laadan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1253207274-7563-1-git-send-email-danms@us.ibm.com \
    --to=danms-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
    --cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox