From: Dan Smith <danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org
Subject: [PATCH] Remove an unnecessary check on socket restart
Date: Thu, 1 Oct 2009 15:04:11 -0700 [thread overview]
Message-ID: <1254434651-6540-1-git-send-email-danms@us.ibm.com> (raw)
This check is removed because it cannot be true because of the
unsigned nature of the value being examined.
Signed-off-by: Dan Smith <danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Cc: serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org
Cc: orenl-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org
---
net/checkpoint.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/net/checkpoint.c b/net/checkpoint.c
index a11ec7a..0087a8a 100644
--- a/net/checkpoint.c
+++ b/net/checkpoint.c
@@ -484,8 +484,7 @@ static int sock_cptrst(struct ckpt_ctx *ctx, struct sock *sk,
(h->sock.state >= TCP_MAX_STATES)) {
ckpt_debug("sock in invalid state: %i", h->sock.state);
return -EINVAL;
- } else if ((h->socket.state < SS_FREE) ||
- (h->socket.state > SS_DISCONNECTING)) {
+ } else if (h->socket.state > SS_DISCONNECTING) {
ckpt_debug("socket in invalid state: %i",
h->socket.state);
return -EINVAL;
--
1.6.0.4
next reply other threads:[~2009-10-01 22:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-01 22:04 Dan Smith [this message]
[not found] ` <1254434651-6540-1-git-send-email-danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-10-01 22:25 ` [PATCH] Remove an unnecessary check on socket restart Serge E. Hallyn
2009-10-01 23:07 ` Oren Laadan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1254434651-6540-1-git-send-email-danms@us.ibm.com \
--to=danms-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
--cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox