From: Dave Hansen <dave-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
To: containers <containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org>
Subject: updated x86_64 eclone() stub
Date: Fri, 04 Dec 2009 07:29:27 -0800 [thread overview]
Message-ID: <1259940567.32391.4950.camel@nimitz> (raw)
This more closely resembles what glibc does.
The last version had a push/popq %ebp. But, after looking at the glibc
code, I believe this to be unnecessary on 64-bit. Suka also pointed out
that we were neglecting to pull the subthread's function argument off
the stack.
I also changed the register being used for the subthread variable to be
rax. This is just to more closely resemble the glibc code. It doesn't
hurt to use it this way mostly because we overwrite it for the exit
syscall anyway.
int eclone(long flags_low, struct clone_args *clone_args, long args_size,
int *pids)
{
long retval;
__asm__ __volatile__(
"movq %5, %%r10\n\t" /* pids in r10*/
"syscall\n\t" /* Linux/x86_64 system call */
"testq %0,%0\n\t" /* check return value */
"jne 1f\n\t" /* jump if parent */
"popq %%rax\n\t" /* get subthread function */
"popq %%rdi\n\t" /* get the subthread function arg */
"call *%%rax\n\t" /* start subthread function */
"movq %6,%0\n\t"
"syscall\n" /* exit system call: exit subthread */
"1:\n\t"
:"=a" (retval)
:"0" (__NR_clone3),/* eax */
"D" (flags_low), /* rdi */
"S" (clone_args), /* rsi */
"d" (args_size), /* rdx */
"m" (pids), /* gets moved to r10 */
"i" (__NR_exit)
:"rbx", "rcx", "r8", "r9", "r10"
);
if (retval < 0) {
errno = -retval;
retval = -1;
}
return retval;
}
-- Dave
next reply other threads:[~2009-12-04 15:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-04 15:29 Dave Hansen [this message]
2009-12-04 16:01 ` updated x86_64 eclone() stub Louis Rilling
[not found] ` <20091204160123.GJ2430-Hu8+6S1rdjywhHL9vcZdMVaTQe2KTcn/@public.gmane.org>
2009-12-04 16:05 ` Dave Hansen
2009-12-04 16:08 ` Louis Rilling
[not found] ` <20091204160825.GL2430-Hu8+6S1rdjywhHL9vcZdMVaTQe2KTcn/@public.gmane.org>
2009-12-04 16:21 ` Dave Hansen
2009-12-04 17:24 ` Louis Rilling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1259940567.32391.4950.camel@nimitz \
--to=dave-23vcf4htsmix0ybbhkvfkdbpr1lh4cv8@public.gmane.org \
--cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox