From: Nathan Lynch <ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
To: Matt Helsley <matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Cc: Linux Containers
<containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>
Subject: Re: [PATCH 04/10] cr_tests: Add dry-run
Date: Mon, 15 Mar 2010 18:32:21 -0500 [thread overview]
Message-ID: <1268695941.4397.135.camel@localhost.localdomain> (raw)
In-Reply-To: <15d3e6bcb9a476add53b72998b45dd62a529871d.1268694050.git.matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
On Mon, 2010-03-15 at 16:01 -0700, Matt Helsley wrote:
> Make the cgroup freezer and do_ckpt() no-ops in order to do dry-runs of the
> tests. This allows us to establish a baseline for those tests that can do
> dry-runsi (i.e. have a dry-run option and use it to avoid restarting checkpoint
> images).
I like this idea and I think this will be useful.
However, is there a reason we shouldn't freeze and thaw as part of the
dry run? I don't have strong feelings on this; just thinking we should
try to minimize the differences in behavior and code coverage.
next prev parent reply other threads:[~2010-03-15 23:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-15 23:00 [PATCH 01/10] cr_tests: Fix quote ordering typo in common.sh Matt Helsley
[not found] ` <69be886209c375c99b00b0745c1b0efdf334dcc3.1268694050.git.matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2010-03-15 23:00 ` [PATCH 02/10] cr_tests: fileio: Fix do_child(i) call Matt Helsley
[not found] ` <39d445e0d6bb5b1420daf672aa48ebabf8648ffe.1268694050.git.matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2010-03-15 23:32 ` Nathan Lynch
[not found] ` <1268695929.4397.134.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2010-03-16 6:04 ` Matt Helsley
[not found] ` <20100316060410.GD3037-52DBMbEzqgQ/wnmkkaCWp/UQ3DHhIser@public.gmane.org>
2010-03-16 6:51 ` [PATCH 11/10] cr_tests: fileio: Add missing voids Matt Helsley
2010-03-16 6:48 ` [PATCH 02/10] cr_tests: fileio: Fix do_child(i) call Matt Helsley
2010-03-15 23:00 ` [PATCH 03/10] cr_tests: libcrtest: Check for NULL checkpoint labels Matt Helsley
2010-03-15 23:01 ` [PATCH 04/10] cr_tests: Add dry-run Matt Helsley
[not found] ` <15d3e6bcb9a476add53b72998b45dd62a529871d.1268694050.git.matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2010-03-15 23:32 ` Nathan Lynch [this message]
[not found] ` <1268695941.4397.135.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2010-03-16 6:25 ` Matt Helsley
2010-03-16 6:54 ` Matt Helsley
2010-03-15 23:01 ` [PATCH 05/10] cr_tests: Factor out close_all_fds() Matt Helsley
2010-03-15 23:01 ` [PATCH 06/10] cr_tests: Factor log() and log_error() Matt Helsley
2010-03-15 23:01 ` [PATCH 07/10] cr_tests: eventfd: run.sh: Remove checkpoint-ready Matt Helsley
2010-03-15 23:01 ` [PATCH 08/10] cr_tests: eventfd: rw: Fixup cgroup path sent to move_to_cgroup Matt Helsley
2010-03-15 23:01 ` [PATCH 09/10] cr_tests: eventfd: Entirely new eventfd testcase Matt Helsley
2010-03-15 23:01 ` [PATCH 10/10] cr_tests: eventfd: Run eventfd from runall.sh Matt Helsley
2010-03-16 14:13 ` [PATCH 01/10] cr_tests: Fix quote ordering typo in common.sh Serge E. Hallyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1268695941.4397.135.camel@localhost.localdomain \
--to=ntl-e+axbwqsrlaavxtiumwx3w@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox