From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Smith Subject: [PATCH] Skip down interfaces Date: Wed, 31 Mar 2010 08:01:26 -0700 Message-ID: <1270047686-28404-1-git-send-email-danms@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org List-Id: containers.vger.kernel.org This makes the netns checkpoint code skip interfaces that are not up. Later, we want to make it possible to checkpoint down interfaces with a flag, but for now this helps prevent people from getting stuck on stock kernels with various unsupported and persistent virtual interfaces, such as tunnel devices. Signed-off-by: Dan Smith Cc: serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org --- net/checkpoint_dev.c | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/net/checkpoint_dev.c b/net/checkpoint_dev.c index bc0415d..1e053f9 100644 --- a/net/checkpoint_dev.c +++ b/net/checkpoint_dev.c @@ -268,7 +268,13 @@ int checkpoint_netns(struct ckpt_ctx *ctx, void *ptr) goto out; for_each_netdev(net, dev) { - ret = checkpoint_obj(ctx, dev, CKPT_OBJ_NETDEV); + if (dev->flags & IFF_UP) + ret = checkpoint_obj(ctx, dev, CKPT_OBJ_NETDEV); + else + /* TODO: There should be a flag to enable checkpoint + * of downed interfaces + */ + ret = 0; if (ret < 0) break; } -- 1.6.2.5