From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: daniel.wagner-98C5kh4wR6ohFhg+JK9F0w@public.gmane.org,
serge.hallyn-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org,
ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org,
nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org,
tgraf-G/eBtMaohhA@public.gmane.org
Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org
Subject: [PATCH 2/3] netcls_cgroup: introduce cgroup_cls_state->is_local
Date: Fri, 16 Nov 2012 19:31:01 -0800 [thread overview]
Message-ID: <1353123062-23193-3-git-send-email-tj@kernel.org> (raw)
In-Reply-To: <1353123062-23193-1-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
cs->is_local will be used to indicate whether the cgroup has its own
configuration or inherited from the parent. It's set when classid is
configured by writing a positive value to cgroup file
"net_cls.classid" and cleared when a negative value is written.
is_local is visible to userland via cgroup file "net_cls.is_local" so
that userland can know whether a cgroup has its config or not.
This patch doesn't yet change hierarchy behavior. The next patch will
use is_local to implement proper hierarchy.
Signed-off-by: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
---
include/net/cls_cgroup.h | 1 +
net/sched/cls_cgroup.c | 23 ++++++++++++++++++++---
2 files changed, 21 insertions(+), 3 deletions(-)
diff --git a/include/net/cls_cgroup.h b/include/net/cls_cgroup.h
index b6a6eeb..5759d98 100644
--- a/include/net/cls_cgroup.h
+++ b/include/net/cls_cgroup.h
@@ -22,6 +22,7 @@ struct cgroup_cls_state
{
struct cgroup_subsys_state css;
u32 classid;
+ bool is_local; /* class id is explicitly configured for this cgroup */
};
extern void sock_update_classid(struct sock *sk);
diff --git a/net/sched/cls_cgroup.c b/net/sched/cls_cgroup.c
index 80a80c4..6e3ef64 100644
--- a/net/sched/cls_cgroup.c
+++ b/net/sched/cls_cgroup.c
@@ -70,19 +70,36 @@ static u64 read_classid(struct cgroup *cgrp, struct cftype *cft)
return cgrp_cls_state(cgrp)->classid;
}
-static int write_classid(struct cgroup *cgrp, struct cftype *cft, u64 value)
+static int write_classid(struct cgroup *cgrp, struct cftype *cft,
+ const char *buf)
{
+ struct cgroup_cls_state *cs = cgrp_cls_state(cgrp);
+ s64 v;
+
+ if (sscanf(buf, "%lld", &v) != 1)
+ return -EINVAL;
+
mutex_lock(&netcls_mutex);
- cgrp_cls_state(cgrp)->classid = (u32) value;
+ cs->classid = clamp_val(v, 0, UINT_MAX);
+ cs->is_local = v >= 0;
mutex_unlock(&netcls_mutex);
return 0;
}
+static u64 read_is_local(struct cgroup *cgrp, struct cftype *cft)
+{
+ return cgrp_cls_state(cgrp)->is_local;
+}
+
static struct cftype ss_files[] = {
{
.name = "classid",
.read_u64 = read_classid,
- .write_u64 = write_classid,
+ .write_string = write_classid,
+ },
+ {
+ .name = "is_local",
+ .read_u64 = read_is_local,
},
{ } /* terminate */
};
--
1.7.11.7
next prev parent reply other threads:[~2012-11-17 3:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1353123062-23193-1-git-send-email-tj@kernel.org>
[not found] ` <20121117.220421.1904738911212014470.davem@davemloft.net>
[not found] ` <20121117.220421.1904738911212014470.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2012-11-18 14:25 ` [PATCHSET cgroup/for-3.8] netcls_cgroup: implement hierarchy support Tejun Heo
[not found] ` <1353123062-23193-4-git-send-email-tj@kernel.org>
[not found] ` <1353123062-23193-4-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2012-11-19 13:47 ` [PATCH 3/3] netcls_cgroup: implement proper " Daniel Wagner
[not found] ` <50AA385A.90503-kQCPcA+X3s7YtjvyW6yDsg@public.gmane.org>
2012-11-19 17:08 ` Tejun Heo
[not found] ` <20121119170859.GI15971-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2012-11-19 19:17 ` Daniel Wagner
[not found] ` <1353123062-23193-1-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2012-11-17 3:31 ` [PATCH 1/3] netcls_cgroup: introduce netcls_mutex Tejun Heo
[not found] ` <1353123062-23193-2-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2012-11-19 14:01 ` Daniel Wagner
2012-11-17 3:31 ` Tejun Heo [this message]
[not found] ` <1353123062-23193-3-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2012-11-19 12:54 ` [PATCH 2/3] netcls_cgroup: introduce cgroup_cls_state->is_local Daniel Wagner
2012-11-19 17:30 ` [PATCH v2 " Tejun Heo
[not found] ` <20121119173026.GJ15971@htj.dyndns.org>
[not found] ` <20121119173026.GJ15971-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2012-11-19 19:18 ` Daniel Wagner
2012-11-17 3:31 ` [PATCH 3/3] netcls_cgroup: implement proper hierarchy support Tejun Heo
2012-11-18 3:04 ` [PATCHSET cgroup/for-3.8] netcls_cgroup: implement " David Miller
2012-11-19 13:59 ` Daniel Wagner
[not found] ` <50AA3B5E.3080701-98C5kh4wR6ohFhg+JK9F0w@public.gmane.org>
2012-11-19 19:01 ` Tejun Heo
2012-11-19 15:07 ` Neil Horman
2012-11-19 19:21 ` Tejun Heo
[not found] ` <20121119192142.GM15971@htj.dyndns.org>
[not found] ` <20121119192142.GM15971-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2012-11-20 5:44 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353123062-23193-3-git-send-email-tj@kernel.org \
--to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=daniel.wagner-98C5kh4wR6ohFhg+JK9F0w@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org \
--cc=serge.hallyn-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org \
--cc=tgraf-G/eBtMaohhA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox