Linux Container Development
 help / color / mirror / Atom feed
From: "Cao Shufeng/曹树烽" <caosf.fnst-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
To: Krister Johansen
	<kjlx-6woCzk5+qv5TrMCiz+cRkdBPR1lH4CV8@public.gmane.org>
Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	"caosf.fnst" <caosf.fnst-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>,
	mashimiao.fnst-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org,
	ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org
Subject: Re: [PATCH v4 3/3] Make core_pattern support namespace
Date: Wed, 26 Oct 2016 11:44:22 +0800	[thread overview]
Message-ID: <1477453462.6965.24.camel@cn.fujitsu.com> (raw)
In-Reply-To: <20161026001938.GB2525-6woCzk5+qv5TrMCiz+cRkdBPR1lH4CV8@public.gmane.org>

Hi Krister:
    Thanks for your review.
在 2016-10-25二的 17:19 -0700,Krister Johansen写道:
> On Tue, Oct 25, 2016 at 03:28:56PM +0800, Cao Shufeng wrote:
> > From: Zhao Lei <zhaolei@cn.fujitsu.com>
> > It will bring us following benefit:
> > 1: Each container can change their own coredump setting
> >    based on operation on /proc/sys/kernel/core_pattern
> > 2: Coredump setting changed in host will not affect
> >    running containers.
> > 3: Support both case of "putting coredump in guest" and
> >    "putting curedump in host".
> 
> Would you explain more about case #3 here?  In particular, I'm curious
> what the impact is for systems that have already configured core_pattern
> with the understanding that the program might be invoked to handle
> either a host or a container core.  In particular, is there any way to
> specify that the container handler fall back to the host handler?
Yes, there is.
We need to run this command in container:
# echo "" > /proc/sys/kernel/core_pattern
Then we will run the program configured in the parent pid namespace.
And the program will run in the context where it's configured.
> 
> On the systems that I've configured, /proc/sys is mounted read-only in the
> container.  The host has a special program run from core_pattern that
For unprivileged containers with read only /proc/ tempfs, we need some
enhancement in container team. We need to configure core_pattern to
empty string before starting the container, so that we can keep backward
compatibility.
> determines which container generated the core.  It then stores the cores
> in a directory that uniquely identifies the container.  The cores are
> isolated on their own filesystem, and given a quota per-container.  The
> eventual goal is to have a service evacuate the cores to an object store
> where we can make them available to the customer via a web service.
It's quit a good solution for current kernel. :)
> 
> Does your change still allow a global handler in the host to process
> cores from containers?  Or is that behavior removed completely?
Yes, we still support a global handler in the host.
But we need to set core_pattern in container to empty string firstly.
> 
> -K
> 
> 

-- 
Best Regards,
Cao Shufeng
--------------------------------------------------
Cao Shufeng
Development Dept.I
Nanjing Fujitsu Nanda Software Tech. Co., Ltd.(FNST)
No.6 Wenzhu Road, Nanjing, 210012, China 
TEL: +86+25-86630566-8552
FUJITSU INTERNAL: 7998-8552
EMail: caosf.fnst@cn.fujitsu.com




_______________________________________________
Containers mailing list
Containers@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/containers

  parent reply	other threads:[~2016-10-26  3:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-25  7:28 [PATCH v4 0/3] Make core_pattern support namespace Cao Shufeng
     [not found] ` <1477380536-3307-1-git-send-email-caosf.fnst-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2016-10-25  7:28   ` [PATCH v4 1/3] Make call_usermodehelper_exec possible to set namespaces Cao Shufeng
2016-10-25  7:28   ` [PATCH v4 2/3] Limit dump_pipe program's permission to init for container Cao Shufeng
2016-10-25  7:28   ` [PATCH v4 3/3] Make core_pattern support namespace Cao Shufeng
     [not found]     ` <1477380536-3307-4-git-send-email-caosf.fnst-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2016-10-26  0:19       ` Krister Johansen
     [not found]         ` <20161026001938.GB2525-6woCzk5+qv5TrMCiz+cRkdBPR1lH4CV8@public.gmane.org>
2016-10-26  3:44           ` Cao Shufeng/曹树烽 [this message]
     [not found]             ` <1477453462.6965.24.camel-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2016-10-27 17:52               ` Krister Johansen
2016-11-09  4:06   ` [PATCH v4 0/3] " Cao Shufeng/曹树烽

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1477453462.6965.24.camel@cn.fujitsu.com \
    --to=caosf.fnst-bthxqxjhjhxqfuhtdcdx3a@public.gmane.org \
    --cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org \
    --cc=kjlx-6woCzk5+qv5TrMCiz+cRkdBPR1lH4CV8@public.gmane.org \
    --cc=mashimiao.fnst-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox