From mboxrd@z Thu Jan 1 00:00:00 1970 From: yamamoto-jCdQPDEk3idL9jVzuh4AOg@public.gmane.org (YAMAMOTO Takashi) Subject: Re: [RFC][ only for review ] memory controller bacground reclaim [3/5] high/low watermark support in res_counter Date: Thu, 29 Nov 2007 12:36:59 +0900 (JST) Message-ID: <20071129033659.352B01CFEB2@siro.lan> References: <20071129122402.101c5fbc.kamezawa.hiroyu@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Return-path: In-Reply-To: Your message of "Thu, 29 Nov 2007 12:24:02 +0900" <20071129122402.101c5fbc.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org Cc: containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org, menage-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, xemul-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org, balbir-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org List-Id: containers.vger.kernel.org > > to me, it seems weird to prevent users from making these values back to > > the default. > > > will fix. > LLONG_MAX-1 for high > LLONG_MAX-2 for low ...? imo it's better to simply allow low == high == limit. > BTW, it should be "low + PAGE_SIZE < high + PAGE_SIZE < limit" ...? it shouldn't, unless you are going to throw away the res_counter abstraction. YAMAMOTO Takashi