Linux Container Development
 help / color / mirror / Atom feed
From: sukadev-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org
To: Oleg Nesterov <oleg-6lXkIZvqkOAvJsYlp49lxw@public.gmane.org>
Cc: Linux Containers
	<containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org>,
	Andrew Morton
	<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
	"Eric W. Biederman"
	<ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>,
	Pavel Emelyanov <xemul-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH] pid: Extend/Fix pid_vnr
Date: Thu, 6 Dec 2007 17:04:24 -0800	[thread overview]
Message-ID: <20071207010424.GB29065@us.ibm.com> (raw)
In-Reply-To: <20071206171513.GB10674-6lXkIZvqkOAvJsYlp49lxw@public.gmane.org>

Oleg Nesterov [oleg-6lXkIZvqkOAvJsYlp49lxw@public.gmane.org] wrote:
| On 12/05, Eric W. Biederman wrote:
| > 
| > +pid_t pid_vnr(struct pid *pid)
| > +{
| > +	return pid_nr_ns(pid, current->nsproxy->pid_ns);
| > +}

Hmm. current->nsproxy be NULL during process exit ?
So this safe as long as pid_vnr() is not called after a
process exits its namespaces. Probably no such callers atm. 

| 
| Excellent!!!
| 
| This allows us to do many cleanups. I am sending the trivial patch just
| as example.
| 
| Oleg.

  parent reply	other threads:[~2007-12-07  1:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-06  4:51 [PATCH] pid: Extend/Fix pid_vnr Eric W. Biederman
     [not found] ` <m11wa0v31c.fsf-T1Yj925okcoyDheHMi7gv2pdwda3JcWeAL8bYrjMMd8@public.gmane.org>
2007-12-06 10:02   ` Pavel Emelyanov
2007-12-06 17:15   ` Oleg Nesterov
     [not found]     ` <20071206171513.GB10674-6lXkIZvqkOAvJsYlp49lxw@public.gmane.org>
2007-12-07  1:04       ` sukadev-r/Jw6+rmf7HQT0dZR+AlfA [this message]
     [not found]         ` <20071207010424.GB29065-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2007-12-07  1:57           ` Serge E. Hallyn
     [not found]             ` <20071207015727.GB32659-6s5zFf/epYLPQpwDFJZrxKsjOiXwFzmk@public.gmane.org>
2007-12-07 18:10               ` Eric W. Biederman
2007-12-06 17:53   ` [PATCH] sys_getsid: don't use ->nsproxy directly Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071207010424.GB29065@us.ibm.com \
    --to=sukadev-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
    --cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
    --cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
    --cc=ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org \
    --cc=oleg-6lXkIZvqkOAvJsYlp49lxw@public.gmane.org \
    --cc=xemul-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox