From: Ingo Molnar <mingo@elte.hu>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Linux Containers <containers@lists.osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Mark timer_stats as incompatible with multiple pid namespaces
Date: Thu, 13 Dec 2007 22:37:11 +0100 [thread overview]
Message-ID: <20071213213710.GB25563@elte.hu> (raw)
In-Reply-To: <m1prxaqo62.fsf@ebiederm.dsl.xmission.com>
* Eric W. Biederman <ebiederm@xmission.com> wrote:
> >> Well struct pid * works in that case if you grab the reference to
> >> it.
> >
> > but the display of the stats might happen much later. The point of
> > this API is to save pid+comm, which gives users a good idea about
> > what caused the events in the past - without having to pin any
> > resource of that task.
>
> Likewise struct pid is designed not to be a problem if pinned. It is a
> little heavier then it used to be with the addition of pid namespace
> support but not much. And if it is to heavy struct pid needs to be
> fixed.
>
> Holding the struct pid very much does not pin the task struct, and it
> shouldn't pin any other resources. I agree 64bytes or so is a bit
> more to pin then 4 bytes but it really isn't a lot.
yeah, and i have no conceptual objections - i just wanted to outline the
thinking behind /proc/timer_stats.
Ingo
next prev parent reply other threads:[~2007-12-13 21:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-12 23:10 [PATCH] Mark timer_stats as incompatible with multiple pid namespaces Eric W. Biederman
2007-12-13 9:01 ` Ingo Molnar
2007-12-13 11:55 ` Eric W. Biederman
2007-12-13 13:04 ` Ingo Molnar
2007-12-13 17:14 ` Eric W. Biederman
2007-12-13 20:26 ` Ingo Molnar
2007-12-13 21:29 ` Eric W. Biederman
2007-12-13 21:37 ` Ingo Molnar [this message]
2007-12-13 21:48 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071213213710.GB25563@elte.hu \
--to=mingo@elte.hu \
--cc=containers@lists.osdl.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox