From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dhaval Giani Subject: Re: Re: Hang with fair cgroup scheduler (reproducer is attached.) Date: Sat, 15 Dec 2007 16:20:36 +0530 Message-ID: <20071215105036.GB26325@linux.vnet.ibm.com> References: <20071214094909.GG11266@elte.hu> <20071214195837.0d3511db.kamezawa.hiroyu@jp.fujitsu.com> <20442799.1197642268756.kamezawa.hiroyu@jp.fujitsu.com> <20071214153607.GB23670@linux.vnet.ibm.com> <20071214153823.GC23670@linux.vnet.ibm.com> Reply-To: Dhaval Giani Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Dmitry Adamushko Cc: Peter Zijlstra , Srivatsa Vaddagiri , Steven Rostedt , containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org, Ingo Molnar , Andrew Morton List-Id: containers.vger.kernel.org On Sat, Dec 15, 2007 at 11:22:08AM +0100, Dmitry Adamushko wrote: > On 14/12/2007, Steven Rostedt wrote: > > > > On Fri, 14 Dec 2007, Dmitry Adamushko wrote: > > > > > > > > argh... it's a consequence of the 'current is not kept within the tree" indeed. > > > > > > > Thanks Dmitry for tracking this down. > > My analysis was flawed (hmm... me was under control of Belgium beer :-) > > The task in not on the runqueue (p->on_rq == 0) at the moment when > put_prev_task_fair() and set_curr_task_fair() get its turn in > sched_move_task()... so dequeue/enqueue_entity() are not triggered, > that's good. > Again, I am probably missing something, but if on_rq == 0, then how is set_curr_task_fair() getting called? -- regards, Dhaval