Linux Container Development
 help / color / mirror / Atom feed
From: Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
To: Paul Menage <menage-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Cc: a.p.zijlstra-/NLkJaSkS4VmR6Xm/wNWPw@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org,
	balbir-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org,
	xemul-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org
Subject: Re: [RFC] Prefixing cgroup generic control filenames with "cgroup."
Date: Thu, 28 Feb 2008 13:21:42 -0800	[thread overview]
Message-ID: <20080228132142.4d4b1eef.akpm@linux-foundation.org> (raw)
In-Reply-To: <6599ad830802281314s25c033d6tc021725ae28aef8d-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

On Thu, 28 Feb 2008 13:14:05 -0800
"Paul Menage" <menage-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> wrote:

> All control files created by cgroup subsystems are given a prefix
> corresponding to their subsystem name. But control files provided by
> cgroups itself have no prefix. Currently that set of files is just
> "tasks", "notify_on_release" and "release_agent", but that set is
> likely to expand in the future. To reduce the risk of clashes, it
> would make sense to prefix these files and any future ones with the
> "cgroup." prefix.
> 
> The only reason that I can see *not* to do this would be for
> compatibility with 2.6.24. Do people think this is a strong enough
> reason to leave the existing names? If distros are planning to ship
> products based on 2.6.24, presumably they'd be adding their own
> patches anyway, so they could add a trivial prefix change patch too.
> (I realise this discussion would have been more useful *before* 2.6.24
> shipped, but I didn't quite get round to it ...)
> 
> A compromise might be to keep "tasks" unprefixed, and say that future
> names get the "cgroup." prefix; in this case I'd be inclined to add
> the prefix to notify_on_release and release_agent on the grounds that
> there's much less chance of breaking anyone with those files since (I
> suspect) they're much less used.
> 
> Note that if you mount a cgroup filesystem with the "noprefix" option,
> which is what the cpuset filesystem wrapper does, no subsystems have
> prefixes, and in this case the "cgroup." prefix wouldn't be used
> either. So this doesn't affect any users that explicitly mount cpusets
> rather than cgroups.
> 
> Thoughts?
> 

It would be easier to judge if we could see the full directory tree.

Because if something is in /foo/bar/cgroup/notify_on_release then
prefixing the filename with "cgroup_" seems pretty pointless.

  parent reply	other threads:[~2008-02-28 21:21 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-28 21:14 [RFC] Prefixing cgroup generic control filenames with "cgroup." Paul Menage
2008-02-28 21:28 ` serge
2008-02-28 23:36 ` Paul Jackson
     [not found]   ` <20080228173618.139f5bb4.pj-sJ/iWh9BUns@public.gmane.org>
2008-02-29  1:03     ` Paul Menage
2008-02-29  1:22       ` Paul Jackson
     [not found] ` <6599ad830802281314s25c033d6tc021725ae28aef8d-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-02-28 21:21   ` Andrew Morton [this message]
2008-02-28 21:28     ` Paul Menage
2008-02-28 21:33       ` serge
2008-02-28 22:06         ` Paul Menage
2008-03-03  8:38           ` Paul Menage
2008-03-03  9:59             ` Balbir Singh
     [not found]       ` <6599ad830802281328q162d0585v3ac6b45a119a4a05-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-02-28 21:40         ` Andrew Morton
2008-02-28 22:06           ` Paul Menage
     [not found]             ` <6599ad830802281406t38e486d8g267df1873bc754c2-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-02-28 22:21               ` Andrew Morton
2008-02-28 22:26                 ` Paul Menage
2008-02-29  5:59                 ` [RFC] [PATCH] " Paul Menage
2008-02-29  6:20                   ` Paul Jackson
2008-02-29  9:34                     ` Paul Menage
2008-02-29 15:30                       ` Paul Jackson
2008-02-29 17:59                         ` Paul Menage
2008-02-29 19:20                           ` Paul Jackson
2008-02-29 11:38   ` [RFC] " Xpl++
2008-03-03  7:23     ` Li Zefan
2008-03-03  9:11       ` Paul Menage
2008-03-05  1:24       ` Paul Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080228132142.4d4b1eef.akpm@linux-foundation.org \
    --to=akpm-de/tnxtf+jlsfhdxvbkv3wd2fqjk+8+b@public.gmane.org \
    --cc=a.p.zijlstra-/NLkJaSkS4VmR6Xm/wNWPw@public.gmane.org \
    --cc=balbir-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
    --cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=menage-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    --cc=xemul-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox