Linux Container Development
 help / color / mirror / Atom feed
From: Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
To: Cedric Le Goater <clg-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>
Cc: Linux Containers
	<containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org>,
	Paul Menage <menage-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
	Linux Kernel Mailing List
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH -mm] remove node_ prefix_from ns subsystem
Date: Wed, 21 May 2008 22:06:57 -0700	[thread overview]
Message-ID: <20080521220657.12e8e8c9.akpm@linux-foundation.org> (raw)
In-Reply-To: <48344409.9090903-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>

On Wed, 21 May 2008 17:47:21 +0200 Cedric Le Goater <clg-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org> wrote:

> From: Cedric Le Goater <clg-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>
> 
> This is a slight change in the namespace cgroup subsystem api.
> 

What are the reasons for making this change?

> ---
>  kernel/cgroup.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: 2.6.26-rc2-mm1/kernel/cgroup.c
> ===================================================================
> --- 2.6.26-rc2-mm1.orig/kernel/cgroup.c
> +++ 2.6.26-rc2-mm1/kernel/cgroup.c
> @@ -2903,7 +2903,7 @@ int cgroup_clone(struct task_struct *tsk
>  	cg = tsk->cgroups;
>  	parent = task_cgroup(tsk, subsys->subsys_id);
>  
> -	snprintf(nodename, MAX_CGROUP_TYPE_NAMELEN, "node_%d", tsk->pid);
> +	snprintf(nodename, MAX_CGROUP_TYPE_NAMELEN, "%d", tsk->pid);
>  
>  	/* Pin the hierarchy */
>  	atomic_inc(&parent->root->sb->s_active);

This is user-visible, isn't it?  Been there since October.  How can we
safely change it now?

  parent reply	other threads:[~2008-05-22  5:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-21 15:47 [PATCH -mm] remove node_ prefix_from ns subsystem Cedric Le Goater
2008-05-21 20:03 ` Serge E. Hallyn
     [not found] ` <48344409.9090903-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>
2008-05-22  5:06   ` Andrew Morton [this message]
     [not found]     ` <20080521220657.12e8e8c9.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2008-05-22  7:11       ` Paul Menage
     [not found]         ` <6599ad830805220011u77313ed7s2c0c9d4a658133cc-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-05-22  7:32           ` Andrew Morton
2008-05-22  7:36             ` Cedric Le Goater
     [not found]               ` <48352277.4010703-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>
2008-05-22  8:10                 ` Andrew Morton
2008-05-22  8:23                   ` Paul Menage
     [not found]                     ` <6599ad830805220123t7a3848eeg244393723d5fd08d-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-05-22  8:36                       ` Andrew Morton
2008-05-22  9:21                         ` Cedric Le Goater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080521220657.12e8e8c9.akpm@linux-foundation.org \
    --to=akpm-de/tnxtf+jlsfhdxvbkv3wd2fqjk+8+b@public.gmane.org \
    --cc=clg-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org \
    --cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=menage-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox