From mboxrd@z Thu Jan 1 00:00:00 1970 From: yamamoto-jCdQPDEk3idL9jVzuh4AOg@public.gmane.org (YAMAMOTO Takashi) Subject: Re: [PATCH 4/4] swapcgroup: modify vm_swap_full for cgroup Date: Mon, 26 May 2008 08:35:32 +0900 (JST) Message-ID: <20080525233532.1EE145A0E@siro.lan> References: <4835686A.9000106@mxp.nes.nec.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Your message of "Thu, 22 May 2008 21:34:50 +0900" <4835686A.9000106-YQH0OdQVrdy45+QrQBaojngSJqDPrsil@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: nishimura-YQH0OdQVrdy45+QrQBaojngSJqDPrsil@public.gmane.org Cc: Lee.Schermerhorn-VXdhtT5mjnY@public.gmane.org, riel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, kosaki.motohiro-+CUm20s59erQFUHtdCDX3A@public.gmane.org, containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org, hugh-DTz5qymZ9yRBDgjK7y7TUQ@public.gmane.org, xemul-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org, balbir-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org List-Id: containers.vger.kernel.org > How about something like this? > > : > usage = swap_cgroup_read_usage(mem); //no need to align to number of page > limit = swap_cgroup_read_limit(mem); //no need to align to number of page > ret = (usage * 2 > limit) || (nr_swap_pages * 2 < total_swap_pages) > : it seems reasonable to me. YAMAMOTO Takashi