From mboxrd@z Thu Jan 1 00:00:00 1970 From: yamamoto-jCdQPDEk3idL9jVzuh4AOg@public.gmane.org (YAMAMOTO Takashi) Subject: Re: [RFD][PATCH] memcg: Move Usage at Task Move Date: Wed, 11 Jun 2008 12:44:46 +0900 (JST) Message-ID: <20080611034446.4C5535A23@siro.lan> References: <20080611122500.677757c6.kamezawa.hiroyu@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Your message of "Wed, 11 Jun 2008 12:25:00 +0900" <20080611122500.677757c6.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org Cc: nishimura-YQH0OdQVrdy45+QrQBaojngSJqDPrsil@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org, menage-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, balbir-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org, xemul-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org List-Id: containers.vger.kernel.org > I'm now considering following logic. How do you think ? > > Assume: move TASK from group:CURR to group:DEST. > > == move_task(TASK, CURR, DEST) > > if (DEST's limit is unlimited) > moving TASK > return success. > > usage = check_usage_of_task(TASK). > > /* try to reserve enough room in destionation */ > if (try_to_reserve_enough_room(DEST, usage)) { > move TASK to DEST and move pages AMAP. > /* usage_of_task(TASK) can be changed while we do this. > Then, we move AMAP. */ > return success; > } > return failure. > == AMAP means that you might leave some random charges in CURR? i think that you can redirect new charges in TASK to DEST so that usage_of_task(TASK) will not grow. YAMAMOTO Takashi