Linux Container Development
 help / color / mirror / Atom feed
From: yamamoto-jCdQPDEk3idL9jVzuh4AOg@public.gmane.org (YAMAMOTO Takashi)
To: kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org
Cc: nishimura-YQH0OdQVrdy45+QrQBaojngSJqDPrsil@public.gmane.org,
	linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
	containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org,
	menage-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
	balbir-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org,
	xemul-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org
Subject: Re: [RFD][PATCH] memcg: Move Usage at Task Move
Date: Wed, 11 Jun 2008 12:45:14 +0900 (JST)	[thread overview]
Message-ID: <20080611034514.D482F5A11@siro.lan> (raw)
In-Reply-To: Your message of "Wed, 11 Jun 2008 11:02:16 +0900" <20080611110216.504faf15.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>

> > having said that, if you decide to put too large tasks into
> > a cgroup with too small limit, i don't think that there are
> > many choices besides OOM-kill and allowing "exceed".
> > 
> IMHO, allowing exceed is harmfull without changing the definition of "limit".
> "limit" is hard-limit, now, not soft-limit. Changing the defintion just for
> this is not acceptable for me. 

even with the current code, the "exceed" condition can be created
by simply lowering the limit.
(well, i know that some of your patches floating around change it.)

> Maybe "move" under limit itself is crazy ops....Hmm...
> 
> Should we allow task move when the destination cgroup is unlimited ?
> Isn't it useful ?

i think it makes some sense.

> > actually, i think that #3 and #5 are somewhat similar.
> > a big difference is that, while #5 shrinks the cgroup immediately,
> > #3 does it later.  in case we need to do OOM-kill, i prefer to do it
> > sooner than later.
> > 
> #3 will not cause OOM-killer, I hope...A user can notice memory shortage.

we are talking about the case where a cgroup's working set is getting
hopelessly larger than its limit.  i don't see why #3 will not
cause OOM-kill.  can you explain?

YAMAMOTO Takashi

  parent reply	other threads:[~2008-06-11  3:45 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-06  1:52 [RFD][PATCH] memcg: Move Usage at Task Move KAMEZAWA Hiroyuki
     [not found] ` <20080606105235.3c94daaf.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2008-06-10  5:50   ` YAMAMOTO Takashi
     [not found]     ` <20080610055032.A8AB25A0E-Pcsii4f/SVk@public.gmane.org>
2008-06-10  8:13       ` KAMEZAWA Hiroyuki
     [not found]         ` <20080610171348.fb7aa360.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2008-06-10 12:57           ` YAMAMOTO Takashi
     [not found]             ` <20080610125703.9E6CE5A11-Pcsii4f/SVk@public.gmane.org>
2008-06-11  2:02               ` KAMEZAWA Hiroyuki
     [not found]                 ` <20080611110216.504faf15.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2008-06-11  3:45                   ` YAMAMOTO Takashi [this message]
     [not found]                     ` <20080611034514.D482F5A11-Pcsii4f/SVk@public.gmane.org>
2008-06-11  4:08                       ` KAMEZAWA Hiroyuki
2008-06-10  7:35   ` Daisuke Nishimura
     [not found]     ` <20080610163550.65c97f6a.nishimura-YQH0OdQVrdy45+QrQBaojngSJqDPrsil@public.gmane.org>
2008-06-10  8:26       ` KAMEZAWA Hiroyuki
     [not found]         ` <20080610172637.39ffff5c.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2008-06-11  3:03           ` Daisuke Nishimura
     [not found]             ` <20080611120345.07ddadc6.nishimura-YQH0OdQVrdy45+QrQBaojngSJqDPrsil@public.gmane.org>
2008-06-11  3:25               ` KAMEZAWA Hiroyuki
     [not found]                 ` <20080611122500.677757c6.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2008-06-11  3:44                   ` YAMAMOTO Takashi
     [not found]                     ` <20080611034446.4C5535A23-Pcsii4f/SVk@public.gmane.org>
2008-06-11  4:14                       ` KAMEZAWA Hiroyuki
     [not found]                         ` <20080611131437.76961fc3.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2008-06-11  4:29                           ` Daisuke Nishimura
     [not found]                             ` <20080611132909.2eb38039.nishimura-YQH0OdQVrdy45+QrQBaojngSJqDPrsil@public.gmane.org>
2008-06-11  4:40                               ` KAMEZAWA Hiroyuki
2008-06-12  5:20                           ` YAMAMOTO Takashi
     [not found]                             ` <20080612052033.ED6FD5A0D-Pcsii4f/SVk@public.gmane.org>
2008-06-12  6:51                               ` KAMEZAWA Hiroyuki
2008-06-11  7:17   ` Paul Menage
     [not found]     ` <6599ad830806110017t5ebeda78id1914d179a018422-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-06-11  7:45       ` KAMEZAWA Hiroyuki
     [not found]         ` <20080611164544.94047336.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2008-06-11  8:04           ` Paul Menage
     [not found]             ` <6599ad830806110104n99cdc7h80063e91d16bf0a5-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-06-11  8:27               ` KAMEZAWA Hiroyuki
     [not found]                 ` <20080611172714.018aa68c.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2008-06-11  8:48                   ` Paul Menage
     [not found]                     ` <6599ad830806110148v65df67f8ge0ccdd56c21c89e0-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-06-12  5:08                       ` KAMEZAWA Hiroyuki
     [not found]                         ` <20080612140806.dc161c77.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2008-06-12 13:17                           ` Serge E. Hallyn
     [not found]                         ` <20080612131748.GB8453-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-06-12 13:34                           ` kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A
     [not found]                             ` <27043861.1213277688814.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2008-06-12 21:08                               ` Serge E. Hallyn
     [not found]                                 ` <20080612210812.GA22948-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-06-13  0:34                                   ` KAMEZAWA Hiroyuki
     [not found]                                     ` <20080613093436.ca1a6ded.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2008-06-13  0:41                                       ` KAMEZAWA Hiroyuki
2008-06-11  8:27       ` Balbir Singh
     [not found]         ` <484F8C76.4080300-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2008-06-11 12:21           ` Daisuke Nishimura
     [not found]         ` <20080611212126.317a95f7.d-nishimura-1T/T2zRcyZr+G+EEi5ephHgSJqDPrsil@public.gmane.org>
2008-06-11 12:51           ` kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A
     [not found]             ` <22652920.1213188663353.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2008-06-11 13:13               ` Balbir Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080611034514.D482F5A11@siro.lan \
    --to=yamamoto-jcdqpdek3idl9jvzuh4aog@public.gmane.org \
    --cc=balbir-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
    --cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
    --cc=kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org \
    --cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
    --cc=menage-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    --cc=nishimura-YQH0OdQVrdy45+QrQBaojngSJqDPrsil@public.gmane.org \
    --cc=xemul-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox