From: sukadev-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org
To: Dave Hansen <dave-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
Cc: kathys <kathys-QcUrd9fbWu1x7SfHBjqd8AC/G2K4zDHf@public.gmane.org>,
Containers <containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org>,
Cedric Le Goater <clg-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>,
Nadia Derbey <Nadia.Derbey-6ktuUTfB/bM@public.gmane.org>
Subject: Re: [GIT PATCH] actually check va randomization
Date: Wed, 11 Jun 2008 11:35:51 -0700 [thread overview]
Message-ID: <20080611183551.GA32012@us.ibm.com> (raw)
In-Reply-To: <1213141919.7261.21.camel@nimitz>
Dave Hansen [dave-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org] wrote:
| Rather than just documenting this in the readme, actually spit
| out a warning on it.
Why not just bail out ? Its mostly unreliable at that point anyway.
Besides, the warning can get buried in lot of other output.
---
From 84d005031a8a17bdca62dc541c296a3bea74658c Mon Sep 17 00:00:00 2001
From: Sukadev Bhattiprolu <sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
Date: Wed, 11 Jun 2008 11:22:17 -0700
Subject: [PATCH] cryo currently requires randomize_va_space to be 0. Fail if it is not.
---
cr.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/cr.c b/cr.c
index db3ada0..217c5e7 100644
--- a/cr.c
+++ b/cr.c
@@ -1464,6 +1464,7 @@ void check_for_va_randomize(void)
return;
fprintf(stderr, "WARNING: %s is set to: %d\n", VA_RANDOM_FILE, enabled);
fprintf(stderr, " Please set to 0 to make cryo more reliable\n");
+ exit(1);
}
void usage(void)
--
1.5.2.5
next prev parent reply other threads:[~2008-06-11 18:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-25 17:24 Userspace checkpoint/restart hack: cryo Dave Hansen
[not found] ` <1209144259.12718.46.camel-FpcvD5N4B9G9xGwK5P7XA+TW4wlIGRCZ@public.gmane.org>
2008-04-28 9:47 ` Cedric Le Goater
[not found] ` <48159D1D.3050302-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>
2008-04-29 14:50 ` Nadia Derbey
[not found] ` <481735A6.8070800-6ktuUTfB/bM@public.gmane.org>
2008-04-29 15:21 ` Cedric Le Goater
[not found] ` <48173CE1.7050503-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>
2008-05-05 8:50 ` Nadia Derbey
[not found] ` <481ECA42.5060603-6ktuUTfB/bM@public.gmane.org>
2008-06-09 13:04 ` Serge E. Hallyn
[not found] ` <20080609130429.GA16297-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-06-09 15:02 ` Nadia Derbey
[not found] ` <484D4612.9000901-6ktuUTfB/bM@public.gmane.org>
2008-06-09 15:23 ` Serge E. Hallyn
[not found] ` <484E1BD3.40401@ozlabs.au.ibm.com>
[not found] ` <484E1BD3.40401-QcUrd9fbWu1x7SfHBjqd8AC/G2K4zDHf@public.gmane.org>
2008-06-10 18:17 ` Serge E. Hallyn
[not found] ` <484F0DC7.5080209@ozlabs.au.ibm.com>
[not found] ` <484F0DC7.5080209-QcUrd9fbWu1x7SfHBjqd8AC/G2K4zDHf@public.gmane.org>
2008-06-10 23:51 ` [GIT PATCH] actually check va randomization Dave Hansen
2008-06-11 3:07 ` Serge E. Hallyn
2008-06-11 18:35 ` sukadev-r/Jw6+rmf7HQT0dZR+AlfA [this message]
[not found] ` <20080611183551.GA32012-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-06-11 19:52 ` Serge E. Hallyn
[not found] ` <20080610181756.GB13817-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-06-17 5:48 ` Userspace checkpoint/restart hack: cryo kathys
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080611183551.GA32012@us.ibm.com \
--to=sukadev-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
--cc=Nadia.Derbey-6ktuUTfB/bM@public.gmane.org \
--cc=clg-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org \
--cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
--cc=dave-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
--cc=kathys-QcUrd9fbWu1x7SfHBjqd8AC/G2K4zDHf@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox