From mboxrd@z Thu Jan 1 00:00:00 1970 From: yamamoto-jCdQPDEk3idL9jVzuh4AOg@public.gmane.org (YAMAMOTO Takashi) Subject: Re: [RFD][PATCH] memcg: Move Usage at Task Move Date: Thu, 12 Jun 2008 14:20:33 +0900 (JST) Message-ID: <20080612052033.ED6FD5A0D@siro.lan> References: <20080611131437.76961fc3.kamezawa.hiroyu@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Your message of "Wed, 11 Jun 2008 13:14:37 +0900" <20080611131437.76961fc3.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org Cc: nishimura-YQH0OdQVrdy45+QrQBaojngSJqDPrsil@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org, menage-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, balbir-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org, xemul-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org List-Id: containers.vger.kernel.org > > i think that you can redirect new charges in TASK to DEST > > so that usage_of_task(TASK) will not grow. > > > > Hmm, to do that, we have to handle complicated cgroup's attach ops. > > at this moving, memcg is pointed by > - TASK->cgroup->memcg(CURR) > after move > - TASK->another_cgroup->memcg(DEST) > > This move happens before cgroup is replaced by another_cgroup. currently cgroup_attach_task calls ->attach callbacks after assigning tsk->cgroups. are you talking about something else? YAMAMOTO Takashi