From: "Serge E. Hallyn" <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: "Eric W. Biederman" <ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
Cc: Linux Containers <containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org>
Subject: Re: [PATCH 0/2] sys_restore prototype
Date: Tue, 29 Jul 2008 13:27:46 -0500 [thread overview]
Message-ID: <20080729182746.GA14456@us.ibm.com> (raw)
In-Reply-To: <m1sktthdp3.fsf-B27657KtZYmhTnVgQlOflh2eb7JE58TQ@public.gmane.org>
Quoting Eric W. Biederman (ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org):
> "Serge E. Hallyn" <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> writes:
>
> > We were talking this morning about what trivial patchset to begin
> > with to get a start on checkpoint and restart. We thought that
> > rather than start with checkpoint, maybe we should start with
> > something that reads a "checkpoint file" and "restarts" a single
> > task. In this case, restart means it sets the process id and
> > executes the file which are found in the checkpoint file.
> >
> > So here's what we whipped up for a half hour this morning,
> > and during some of Mark's talk this afternoon.
> >
> > It refuses to run if it isn't the container init, so you must
> > unshare your pidns before calling sys_restore().
>
> A reasonable approximation.
>
> Dave Hansen made a good point when he asked how do we graft a restored
> checkpoint into the rest of the system. Requiring us to unshare
> everything we intend to unshare before restore achieves this easily,
> and you are following in that model.
>
> That leads to an interesting implication. We don't need to set the pid
> of the first process. At most we can verify that the pid is the same.
> If we have unshared the pid namespace the pid will be 1 and the needed
> pid of the first process will be 1.
>
> More later.
Good point. Sounds like our trivial prototype was still way
over-featureful :)
-serge
prev parent reply other threads:[~2008-07-29 18:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-25 22:56 [PATCH 0/2] sys_restore prototype Serge E. Hallyn
[not found] ` <20080725225655.GA28276-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-07-25 22:58 ` [PATCH 1/2] introduce sys_restore Serge E. Hallyn
2008-07-25 22:59 ` [PATCH 2/2] sys_restore: set the pid number Serge E. Hallyn
[not found] ` <20080725225935.GB28764-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-07-27 2:33 ` [Devel] " Pavel Emelyanov
[not found] ` <488BDE7D.7090602-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
2008-07-29 18:31 ` Serge E. Hallyn
2008-07-28 22:00 ` [PATCH 0/2] sys_restore prototype Eric W. Biederman
[not found] ` <m1sktthdp3.fsf-B27657KtZYmhTnVgQlOflh2eb7JE58TQ@public.gmane.org>
2008-07-29 18:27 ` Serge E. Hallyn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080729182746.GA14456@us.ibm.com \
--to=serue-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
--cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
--cc=ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox