Linux Container Development
 help / color / mirror / Atom feed
From: sukadev-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org
To: Alan Cox <alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org>
Cc: Containers <containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org>,
	hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org
Subject: ptem01 LTP failure in ttydev-0909
Date: Thu, 11 Sep 2008 13:11:59 -0700	[thread overview]
Message-ID: <20080911201159.GA17071@us.ibm.com> (raw)

Alan,

LTP testcases/kernel/pty/ptem01 is failing on ttydev-0909. The test
passed on ttydev-0828.

The test changes the window size using the slave-fd and expects that
it won't affect the window-size on master-fd. With this change, we
return the slave's window size and test fails.

I suspect that it is due to following change in ttydev.  

Is the test bogus now ?

Suka


commit 4f0fa9c9e6557442b583a687066bebd607246220
Author: Alan Cox <alan-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Date:   Mon Sep 8 13:49:19 2008 -0700

    tty: Termios locking - sort out real_tty confusions and lock reads

    This moves us towards sanity and should mean our termios locking is now
    complete and comprehensive.

diff --git a/drivers/char/tty_io.c b/drivers/char/tty_io.c
index 69b1766..7eabfbb 100644
--- a/drivers/char/tty_io.c
+++ b/drivers/char/tty_io.c
@@ -2595,7 +2595,7 @@ long tty_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
        case TIOCSTI:
                return tiocsti(tty, p);
        case TIOCGWINSZ:
-               return tiocgwinsz(tty, p);
+               return tiocgwinsz(real_tty, p);

             reply	other threads:[~2008-09-11 20:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-11 20:11 sukadev-r/Jw6+rmf7HQT0dZR+AlfA [this message]
     [not found] ` <20080911201159.GA17071-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-09-16 14:48   ` ptem01 LTP failure in ttydev-0909 Alan Cox
     [not found]     ` <20080916154848.49337bf0-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org>
2008-09-19  4:14       ` sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8
     [not found]         ` <20080919041408.GA31412-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-09-24 12:36           ` Subrata Modak
     [not found]             ` <1222259777.5395.7.camel-NRFfyExJdYpgXGGE5LP+UZlqa2bBAFbm0E9HWUfgJXw@public.gmane.org>
2008-11-01 20:33               ` sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8
     [not found]                 ` <20081101203303.GG24472-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-11-03  7:26                   ` Subrata Modak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080911201159.GA17071@us.ibm.com \
    --to=sukadev-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
    --cc=alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org \
    --cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
    --cc=hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox