From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH 2/2] net: Guaranetee the proper ordering of the loopback device. v2 Date: Fri, 07 Nov 2008 22:55:29 -0800 (PST) Message-ID: <20081107.225529.45534653.davem@davemloft.net> References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: netdev-owner@vger.kernel.org To: ebiederm@xmission.com Cc: dlezcano@fr.ibm.com, containers@lists.osdl.org, den@openvz.org, xemul@openvz.org, netdev@vger.kernel.org List-Id: containers.vger.kernel.org From: ebiederm@xmission.com (Eric W. Biederman) Date: Thu, 06 Nov 2008 07:36:00 -0800 > I was recently hunting a bug that occurred in network namespace > cleanup. In looking at the code it became apparrent that we have > and will continue to have cases where if we have anything going > on in a network namespace there will be assumptions that the > loopback device is present. Things like sending igmp unsubscribe > messages when we bring down network devices invokes the routing > code which assumes that at least the loopback driver is present. > > Therefore to avoid magic initcall ordering hackery that is hard > to follow and hard to get right insert a call to register the > loopback device directly from net_dev_init(). This guarantes > that the loopback device is the first device registered and > the last network device to go away. > > But do it carefully so we register the loopback device after > we clear dev_boot_phase. > > Signed-off-by: Eric W. Biederman Applied.