From: Ingo Molnar <mingo@elte.hu>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Dave Hansen <dave@linux.vnet.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
containers@lists.osdl.org, fweisbec@gmail.com,
LKML <linux-kernel@vger.kernel.org>,
srostedt@redhat.com,
Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>,
"Serge E. Hallyn" <serue@us.ibm.com>
Subject: Re: [PATCH 1/3] ftrace: add function tracing to single thread
Date: Wed, 26 Nov 2008 07:32:01 +0100 [thread overview]
Message-ID: <20081126063201.GF9732@elte.hu> (raw)
In-Reply-To: <m1abbnc8ff.fsf@frodo.ebiederm.org>
* Eric W. Biederman <ebiederm@xmission.com> wrote:
> Steven Rostedt <rostedt@goodmis.org> writes:
>
> > On Tue, 25 Nov 2008, Eric W. Biederman wrote:
> >
> > I'm speechless too.
>
> I'm a bit tired so probably am pushing to hard.
>
> At the same time I don't see a single reason not to use struct pid
> for what it was designed for. Identifying tasks. pid_t's really
> only belong at the border.
>
> I can see in the tracer when grabbing numbers you might not be able
> to follow pointers. For that I see justification for using
> task->pid. For the comparison I just don't see it.
i dont see the point of the complexity you are advocating. 99.9% of
the users run a unique PID space.
Tracing is about keeping stuff simple. On containers we could also
trace the namespace ID (is there an easy ID for the namespace, as an
easy extension to the very nice PID concept that Unix introduced
decades ago?) and be done with it.
Ingo
next prev parent reply other threads:[~2008-11-26 6:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20081125223421.795046329@goodmis.org>
[not found] ` <20081125223456.976670734@goodmis.org>
[not found] ` <20081125144221.66eb99ad.akpm@linux-foundation.org>
[not found] ` <alpine.DEB.1.10.0811251800130.26424@gandalf.stny.rr.com>
[not found] ` <20081125153104.ecdceed4.akpm@linux-foundation.org>
2008-11-26 0:11 ` [PATCH 1/3] ftrace: add function tracing to single thread Steven Rostedt
2008-11-26 0:53 ` Dave Hansen
2008-11-26 1:01 ` Steven Rostedt
[not found] ` <m1zljndrb6.fsf@frodo.ebiederm.org>
2008-11-26 5:01 ` Steven Rostedt
2008-11-26 6:23 ` Eric W. Biederman
2008-11-26 6:32 ` Ingo Molnar [this message]
2008-11-26 7:02 ` Eric W. Biederman
2008-11-26 7:18 ` Ingo Molnar
2008-11-26 8:48 ` Eric W. Biederman
2008-11-26 5:20 ` Eric W. Biederman
2008-11-26 16:36 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081126063201.GF9732@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=containers@lists.osdl.org \
--cc=dave@linux.vnet.ibm.com \
--cc=ebiederm@xmission.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=serue@us.ibm.com \
--cc=srostedt@redhat.com \
--cc=sukadev@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox