From: Ingo Molnar <mingo@elte.hu>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
containers@lists.osdl.org,
Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>,
"Serge E. Hallyn" <serue@us.ibm.com>,
Steven Rostedt <srostedt@redhat.com>
Subject: Re: [PATCH 1/5] ftrace: add function tracing to single thread
Date: Wed, 26 Nov 2008 07:54:25 +0100 [thread overview]
Message-ID: <20081126065425.GA26036@elte.hu> (raw)
In-Reply-To: <m1hc5vasye.fsf@frodo.ebiederm.org>
* Eric W. Biederman <ebiederm@xmission.com> wrote:
> > +/* ftrace_pid_trace >= 0 will only trace threads with this pid */
> > +static int ftrace_pid_trace = -1;
>
> Why not?
> static struct pid *ftrace_pid_trace = NULL;
ok, looks reasonably simple at first sight.
Steve, mind sending the conversion of this facility to struct pid as a
delta patch? (that would have education purposes as well, for similar
situations)
Ingo
next prev parent reply other threads:[~2008-11-26 6:54 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-26 5:16 [PATCH 0/5] ftrace: rebase patches on top of tip/master + some extras Steven Rostedt
2008-11-26 5:16 ` [PATCH 1/5] ftrace: add function tracing to single thread Steven Rostedt
2008-11-26 5:29 ` Andrew Morton
2008-11-26 16:43 ` Steven Rostedt
2008-11-26 6:42 ` Eric W. Biederman
2008-11-26 6:54 ` Ingo Molnar [this message]
2008-11-26 16:55 ` Steven Rostedt
2008-11-26 16:54 ` Steven Rostedt
2008-11-26 5:16 ` [PATCH 2/5] ftrace: use code patching for ftrace graph tracer Steven Rostedt
[not found] ` <20081126051709.774546196-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org>
2008-11-26 5:35 ` Andrew Morton
2008-11-26 6:52 ` Harvey Harrison
2008-11-26 8:04 ` Andrew Morton
2008-11-26 8:27 ` Harvey Harrison
2008-11-26 8:35 ` Andrew Morton
[not found] ` <20081126003553.12d38150.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2008-11-26 8:44 ` Harvey Harrison
2008-11-26 9:05 ` Andrew Morton
2008-11-26 9:22 ` Harvey Harrison
2008-11-26 16:46 ` Steven Rostedt
2008-11-26 18:02 ` Andrew Morton
2008-11-26 18:06 ` Harvey Harrison
2008-11-26 5:16 ` [PATCH 3/5] ftrace: let function tracing and function return run together Steven Rostedt
2008-11-26 5:16 ` [PATCH 4/5] ftrace: add thread comm to function graph tracer Steven Rostedt
2008-11-26 5:37 ` Andrew Morton
2008-11-26 16:48 ` Steven Rostedt
2008-11-26 18:04 ` Andrew Morton
2008-11-26 5:16 ` [PATCH 5/5] ftrace: add cpu annotation for " Steven Rostedt
2008-11-26 5:39 ` Andrew Morton
2008-11-26 5:47 ` Ingo Molnar
2008-11-26 5:55 ` Andrew Morton
2008-11-26 16:49 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081126065425.GA26036@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=containers@lists.osdl.org \
--cc=ebiederm@xmission.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=serue@us.ibm.com \
--cc=srostedt@redhat.com \
--cc=sukadev@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox