From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [PATCH 1/3] ftrace: add function tracing to single thread Date: Wed, 26 Nov 2008 08:18:34 +0100 Message-ID: <20081126071834.GF26036@elte.hu> References: <20081125153104.ecdceed4.akpm@linux-foundation.org> <1227660839.12109.52.camel@nimitz> <20081126063201.GF9732@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: "Eric W. Biederman" Cc: Steven Rostedt , Dave Hansen , Andrew Morton , containers@lists.osdl.org, fweisbec@gmail.com, LKML , srostedt@redhat.com, Sukadev Bhattiprolu , "Serge E. Hallyn" List-Id: containers.vger.kernel.org * Eric W. Biederman wrote: > Ingo Molnar writes: > > > i dont see the point of the complexity you are advocating. 99.9% of > > the users run a unique PID space. > > I'm not advocating complexity. I'm advocating using the same APIs as > the rest of the kernel, for doing the same functions. > > > Tracing is about keeping stuff simple. On containers we could also > > trace the namespace ID (is there an easy ID for the namespace, as an > > easy extension to the very nice PID concept that Unix introduced > > decades ago?) and be done with it. > > I don't really care about the pid namespace in this context. > > I am just asking that we compare a different field in the task > struct. > > I am asking that we don't accumulate new users of an old crufty bug > prone API, for no good reason. i dont disagree about the change, but i'm curious, what's bug-prone about current->pid? It certainly worked quite well for the first 15 years. Ingo