From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH 1/3] ftrace: graph of a single function Date: Wed, 3 Dec 2008 13:07:41 -0800 Message-ID: <20081203130741.473c1262.akpm@linux-foundation.org> References: <20081203203656.776893226@goodmis.org> <20081203203828.920111079@goodmis.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20081203203828.920111079-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Steven Rostedt Cc: fweisbec-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dave-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org, srostedt-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org, containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org, mingo-X9Un+BFzKDI@public.gmane.org, sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org, arjan-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org List-Id: containers.vger.kernel.org On Wed, 03 Dec 2008 15:36:57 -0500 Steven Rostedt wrote: > +static int g_show(struct seq_file *m, void *v) > +{ > + unsigned long *ptr = v; > + char str[KSYM_SYMBOL_LEN]; > + > + if (!ptr) > + return 0; > + > + kallsyms_lookup(*ptr, NULL, NULL, NULL, str); > + > + seq_printf(m, "%s\n", str); Can we use %pF here? > + return 0; > +}