From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steven Rostedt Subject: [PATCH 1/3] fix the do_each_pid_task macro Date: Thu, 04 Dec 2008 00:26:39 -0500 Message-ID: <20081204052734.913191217@goodmis.org> References: <20081204052638.425740534@goodmis.org> Return-path: Content-Disposition: inline; filename=0001-fix-the-do_each_pid_task-macro.patch Sender: linux-kernel-owner@vger.kernel.org To: linux-kernel@vger.kernel.org Cc: Ingo Molnar , Andrew Morton , Frederic Weisbecker , Peter Zijlstra , Dave Hansen , containers@lists.osdl.org, Eric Biederman , Sukadev Bhattiprolu , "Serge E. Hallyn" , Steven Rostedt List-Id: containers.vger.kernel.org From: Steven Rostedt Impact: fix This patch adds parenthesis around 'pid' in the do_each_pid_task macro to allow callers to pass in more complex parameters. e.g. do_each_pid_task(*pid, type, task) Signed-off-by: Steven Rostedt Cc: Eric W. Biederman --- include/linux/pid.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/pid.h b/include/linux/pid.h index d7e98ff..bb206c5 100644 --- a/include/linux/pid.h +++ b/include/linux/pid.h @@ -147,9 +147,9 @@ pid_t pid_vnr(struct pid *pid); #define do_each_pid_task(pid, type, task) \ do { \ struct hlist_node *pos___; \ - if (pid != NULL) \ + if ((pid) != NULL) \ hlist_for_each_entry_rcu((task), pos___, \ - &pid->tasks[type], pids[type].node) { + &(pid)->tasks[type], pids[type].node) { /* * Both old and new leaders may be attached to -- 1.5.6.5 --