From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sukadev Bhattiprolu Subject: Re: [PATCH 4/7][v7] Protect cinit from unblocked SIG_DFL signals Date: Mon, 19 Jan 2009 17:07:34 -0800 Message-ID: <20090120010734.GB14612@us.ibm.com> References: <20090117202638.GA11825@us.ibm.com> <20090117203621.GE11825@us.ibm.com> <20090117221242.GA3962@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20090117221242.GA3962@redhat.com> Sender: linux-kernel-owner@vger.kernel.org To: Oleg Nesterov Cc: ebiederm@xmission.com, roland@redhat.com, bastian@waldi.eu.org, daniel@hozac.com, xemul@openvz.org, containers@lists.osdl.org, linux-kernel@vger.kernel.org List-Id: containers.vger.kernel.org Oleg Nesterov [oleg@redhat.com] wrote: | On 01/17, Sukadev Bhattiprolu wrote: | > | > @@ -1331,7 +1341,7 @@ int send_sigqueue(struct sigqueue *q, struct task_struct *t, int group) | > goto ret; | > | > ret = 1; /* the signal is ignored */ | > - if (!prepare_signal(sig, t)) | > + if (!prepare_signal(sig, t, 1)) | | Hmm, just noticed. This looks wrong, it should be prepare_signal(sig, t, 0), | no? Grr. I missed that when we changed the parameter from 'same-ns' to 'from_ancestor_ns' and inverted the logic. | | For example, /sbin/init can create the posix timer with sigev_signo = SIGKILL | and it won't be killed before this patch. | | This also looks wrong from the masquerading pov. | | | Otherwise, the patches 1-6 are imho fine. Thanks, Will resend this patch. Sukadev