Linux Container Development
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
To: Sukadev Bhattiprolu
	<sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
Cc: "David C. Hansen"
	<haveblue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org,
	Containers <containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org>,
	hch-jcswGhMUV9g@public.gmane.org,
	Alan Cox <alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org>
Subject: Re: [RFC][PATCH] devpts: Must release s_umount on error
Date: Sun, 1 Feb 2009 17:33:01 +0100	[thread overview]
Message-ID: <20090201163301.GD3416@lst.de> (raw)
In-Reply-To: <20090129063330.GB22898-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>

On Wed, Jan 28, 2009 at 10:33:30PM -0800, Sukadev Bhattiprolu wrote:
> 
> From: Sukadev Bhattiprolu <sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
> Date: Wed, 28 Jan 2009 16:57:12 -0800
> Subject: [RFC][PATCH] devpts: Must release s_umount on error
> 
> We should drop the ->s_umount mutex if an error occurs after the
> sget()/grab_super() call. This was introduced when adding support
> for multiple instances of devpts and noticed during a code review/reorg.

Looks good and should probably be submitted for 2.6.29.

      parent reply	other threads:[~2009-02-01 16:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-29  6:33 [RFC][PATCH] devpts: Must release s_umount on error Sukadev Bhattiprolu
     [not found] ` <20090129063330.GB22898-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-02-01 16:33   ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090201163301.GD3416@lst.de \
    --to=hch-jcswghmuv9g@public.gmane.org \
    --cc=alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org \
    --cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
    --cc=haveblue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
    --cc=hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox